Skip to content

Refine pom files#1805

Merged
sre-ci-robot merged 1 commit intomilvus-io:masterfrom
yhmo:mm
Apr 15, 2026
Merged

Refine pom files#1805
sre-ci-robot merged 1 commit intomilvus-io:masterfrom
yhmo:mm

Conversation

@yhmo
Copy link
Copy Markdown
Contributor

@yhmo yhmo commented Apr 15, 2026

No description provided.

Copilot AI review requested due to automatic review settings April 15, 2026 09:48
@sre-ci-robot
Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: yhmo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Note

Copilot was unable to run its full agentic suite in this review.

Consolidates Maven dependency management and cleans up documentation/version properties across modules to reduce duplication and fix a few configuration typos.

Changes:

  • Centralized common dependencyManagement entries (gRPC/Testcontainers BOMs and shared library versions) into the root pom.xml.
  • Removed duplicated dependency management blocks from module POMs and fixed the minio version property typo.
  • Updated/added documentation (examples README, dependency snippets) and trimmed outdated sections.

Reviewed changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
sdk-core/pom.xml Removes module-level dependencyManagement so versions are managed at the parent/root level.
sdk-bulkwriter/pom.xml Removes duplicated managed deps and fixes MinIO property reference.
pom.xml Adds centralized dependencyManagement, fixes MinIO property name, removes hardcoded javadoc executable.
examples/README.md Adds standalone build/run instructions for examples project.
README.md Updates SLF4J version snippets and removes an empty “Documentation” header section.
DEVELOPMENT.md Removes older setup/update sections and clarifies unit test locations.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread sdk-bulkwriter/pom.xml Outdated
Comment thread DEVELOPMENT.md
Comment thread DEVELOPMENT.md
Signed-off-by: yhmo <yihua.mo@zilliz.com>
@mergify mergify bot added the ci-passed label Apr 15, 2026
@yhmo yhmo added the lgtm label Apr 15, 2026
@sre-ci-robot sre-ci-robot merged commit d07430c into milvus-io:master Apr 15, 2026
6 checks passed
@yhmo yhmo deleted the mm branch April 16, 2026 04:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants