Add file resource interfaces#1802
Conversation
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: yhmo The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
There was a problem hiding this comment.
Pull request overview
This PR adds Milvus “file resource” support to the Java v2 SDK utility layer by introducing request/response DTOs, wiring new RPC calls through UtilityService and MilvusClientV2, and extending the existing unit-test stubs and tests to cover the new APIs.
Changes:
- Add new utility request/response models for file resources (
AddFileResourceReq,RemoveFileResourceReq,ListFileResourcesReq,ListFileResourcesResp,FileResourceInfo). - Implement
addFileResource,removeFileResource, andlistFileResourcesinUtilityServiceand expose them inMilvusClientV2. - Extend mock stubbing in
BaseTestand add corresponding tests inUtilityTest.
Reviewed changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| sdk-core/src/test/java/io/milvus/v2/service/utility/UtilityTest.java | Adds tests for add/remove/list file resource APIs. |
| sdk-core/src/test/java/io/milvus/v2/BaseTest.java | Adds Mockito stubs for the new file resource RPCs. |
| sdk-core/src/main/java/io/milvus/v2/service/utility/response/ListFileResourcesResp.java | New response wrapper for listing file resources. |
| sdk-core/src/main/java/io/milvus/v2/service/utility/response/FileResourceInfo.java | New SDK-side model for file resource info. |
| sdk-core/src/main/java/io/milvus/v2/service/utility/request/RemoveFileResourceReq.java | New request model for removing a file resource. |
| sdk-core/src/main/java/io/milvus/v2/service/utility/request/ListFileResourcesReq.java | New request model for listing file resources. |
| sdk-core/src/main/java/io/milvus/v2/service/utility/request/AddFileResourceReq.java | New request model for adding a file resource. |
| sdk-core/src/main/java/io/milvus/v2/service/utility/UtilityService.java | Adds RPC implementations for add/remove/list file resources. |
| sdk-core/src/main/java/io/milvus/v2/client/MilvusClientV2.java | Exposes new file resource APIs on the public client. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Signed-off-by: yhmo <yihua.mo@zilliz.com>
No description provided.