Skip to content

feat(lualine): display provider and model name#83

Merged
milanglacier merged 8 commits intomilanglacier:feat/lualine-updatefrom
Jari27:always-display-lualine
Apr 20, 2025
Merged

feat(lualine): display provider and model name#83
milanglacier merged 8 commits intomilanglacier:feat/lualine-updatefrom
Jari27:always-display-lualine

Conversation

@Jari27
Copy link
Copy Markdown
Contributor

@Jari27 Jari27 commented Apr 19, 2025

Two changes:

  1. Display provider + model name
  2. Display connection when idle (after first request)

Should we make this configurable? If so, is the best place in the normal opts or in the lualine opts?

Before entering insert mode (no change with current behaviour):
Screenshot 2025-04-19 213422

During request (insert mode)
Screenshot 2025-04-19 213430

After first request (normal mode)
Screenshot 2025-04-19 213447

@Jari27 Jari27 force-pushed the always-display-lualine branch from ffbda69 to 62c68af Compare April 19, 2025 19:33
@milanglacier
Copy link
Copy Markdown
Owner

milanglacier commented Apr 19, 2025

Thanks for the update. Let’s make this configured separately in lualine.

something like this: require("minuet.lualine").setup { }.

The setup function is not required to let the user to call. If the user does not call setup, the default options are used.

@milanglacier
Copy link
Copy Markdown
Owner

Can we use : instead of /?

the reason is that Minuet change_model command uses : instead of /, we want to be consistent here.

@Jari27
Copy link
Copy Markdown
Contributor Author

Jari27 commented Apr 19, 2025

Added your requested changed -- I made it all configurable. Reason I prefer using the '/' is because otherwise the request looks like this: ollama:qwen-2.5-coder:7b: 1/3 which too me looked like too many colons in a row. Anyway, configurable now.

Configuration works like all other lualine components, i.e.

-- ...
section_x = {
          { require("minuet.lualine"), display_name = "provider", provider_model_separator = "/" },
}
-- ...

@milanglacier
Copy link
Copy Markdown
Owner

Thanks, I understand your concern, but I still prefer consistent naming style, thanks for your understanding.

Can we show something like this instead? ollama:qwen-2.5-coder:7b (1/3) to avoid the last colon?

@Jari27
Copy link
Copy Markdown
Contributor Author

Jari27 commented Apr 20, 2025

Naming is now consistent, it's defaulting to a colon but users have the ability to override it. I've added documentation for that now too.

Do you want me to still change the formatting for the requests as you described above?

@milanglacier
Copy link
Copy Markdown
Owner

Do you want me to still change the formatting for the requests as you described above?

Yes, in virtual text we used (1/3) to indicate the different completion items, I think we also want to add parenthesis here, thanks.

@Jari27
Copy link
Copy Markdown
Contributor Author

Jari27 commented Apr 20, 2025

There you go :)
Screenshot 2025-04-20 021032

@milanglacier milanglacier changed the base branch from main to feat/lualine-update April 20, 2025 16:37
@milanglacier milanglacier merged commit 287bccf into milanglacier:feat/lualine-update Apr 20, 2025
1 check passed
@milanglacier
Copy link
Copy Markdown
Owner

Thanks, I will test this for a while and merge it into the main branch

@milanglacier
Copy link
Copy Markdown
Owner

I have merged this PR into the main branch.

Note that I have added a new lualine option display_on_idle which will be false by default (to avoid making it a breaking change)

You need to set this value to true to show the display name on idle.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants