Retire the models.dih.earth monitor - #72
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Warning Review limit reachedNext included review available in 43 minutes. View limit detailsLimit details: You’ve used the included review currently available. You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Review configuration: ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (2)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 3e2b1a7bbb
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| const isManagedRedirect = existing.friendlyName.startsWith("EOS redirect | "); | ||
| if (isManagedRedirect && !desiredUrls.has(normalizeUrl(existing.url))) { |
There was a problem hiding this comment.
Preserve named monitors when repairing URL drift
When a repository-managed monitor still has a desired friendly name but its UptimeRobot URL has drifted, this URL-only test deletes it. The later lookup still finds the deleted object by friendly name in the unchanged existingMonitors array and attempts to PATCH its now-invalid ID, so the sync fails and leaves the monitor absent until another run creates it. Treat a monitor as obsolete only when neither its name nor URL is desired, or remove deleted entries before the update loop.
Useful? React with 👍 / 👎.
Summary
Validation