fix: suppress console on windows release builds#1006
Open
chakany wants to merge 1 commit intomikedilger:masterfrom
Open
fix: suppress console on windows release builds#1006chakany wants to merge 1 commit intomikedilger:masterfrom
chakany wants to merge 1 commit intomikedilger:masterfrom
Conversation
Owner
|
I find the console to be important. I know it seems like a debugging leftover, or annoying, and it prints way too much stuff, but the main UI window doesn't have enough space to show most of the error conditions that you might want to be aware of. A better path forward would be to have an error indicator in the UI that you can click to open which shows long lines of errors, and of course to prune back the output, and only then remove the console. You can run without the console if it works well enough for you and you don't think you can do anything about the conditions that get printed. But by default, for now, I think I'll leave it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I installed gossip on my Windows 11 machine using the msi installer and noticed that when I opened it it would also open a terminal window to log events. I checked the codebase, and compared it against my own egui app's codebase, and found that the macro that controls this behavior was set differently. When I changed it and re-compiled in release mode, the terminal window no longer appeared.
It is a simple one-line change.