Honour a user-set RTSP port for AirPlay 2 - #2277
Merged
Merged
Conversation
AirPlay 2 overwrote config.port with 7000, ignoring -p / general.port (which classic AirPlay honours). Default the port only when unset instead, so an explicit port takes effect for AP2 too. mdns_register already advertises config.port, so the SRV record carries the chosen port -- which lets several AirPlay 2 instances share one IP on distinct ports (verified on iOS: clients follow the SRV-advertised port). Unset behaviour is unchanged (7000 for AP2, 5000 for classic).
Owner
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
AirPlay 2 overwrote
config.portwith 7000, discarding-p/general.port(which classic AirPlay honours). This defaults the port only when it is unset, so
an explicit port takes effect for AirPlay 2 as well.
mdns_registeralreadyadvertises
config.port, so the SRV record carries the chosen port -- andAirPlay 2 clients follow it (verified on iOS), which lets several AirPlay 2
instances share one IP on distinct ports (7000, 7001, ...), with no per-instance
address, macvlan, or veth.
Unset behaviour is unchanged: 7000 for AirPlay 2, 5000 for classic. The only
change is that AirPlay 2 now honours a port it previously ignored; since the SRV
advertises whatever it binds, clients follow -- worth a release note rather than a
new setting.
Background and testing in #2266. Independently confirmed there by @jslove, who is
now running eleven AirPlay 2 instances on a single IP (ports 7000-7010) in
production.