Add general.address / --address to bind the RTSP listener to a specific local IP - #2275
Merged
Merged
Conversation
… local IP rtsp_listen_loop() passed NULL as the getaddrinfo node, always binding the listening (RTSP) socket to the wildcard address (all interfaces). Add an optional local address, settable via the general.address config key and a --address CLI flag (CLI overrides config, mirroring general.port / -p), and pass it as the getaddrinfo node. NULL preserves the existing all-addresses behaviour; an IP literal yields a single-address bind. The mDNS advertisement scope (general.interface) is intentionally left separate: --address restricts the socket, general.interface the advertisement.
Owner
|
Thanks for this! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
rtsp_listen_loop()passesNULLas thegetaddrinfonode, so the RTSP listeneralways binds the wildcard address (all local addresses);
general.interfaceonlyscopes the mDNS advertisement.
This adds an optional
general.address(and matching--address), passed as thebind node instead:
CLI overrides config, mirroring
general.port/-p. The advertisement scope(
general.interface) is intentionally left separate:--addressrestricts thesocket,
interfacethe advertisement.Motivation and the broader multi-instance discussion are in #2266. Tested with
classic and AirPlay 2 builds, including end-to-end playback.