Fix build - #2988
Merged
Merged
Conversation
The matrix was switched from windows-latest to windows-2022, but the Windows x64 ffmpeg download, electron-builder, e2e and screenshot upload steps were still gated on matrix.os == 'windows-latest', so they never ran and the artifact upload failed with 'File dist/LosslessCut-win-x64.7z does not exist'. Gate them on runner.os == 'Windows' && matrix.os != 'windows-11-arm' instead, so they are independent of the exact Windows runner image. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01PWvFPqUcXUzsYf3DY7RziJ
Gating steps on the exact matrix image name (windows-latest, windows-11-arm) breaks silently whenever the image in the matrix is renamed, as happened with the windows-2022 switch. runner.os and runner.arch describe what we actually care about and are independent of the image label. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01PWvFPqUcXUzsYf3DY7RziJ
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.