Fix clipboard copy formatting based on selection dimensions in Stack Viewer #2332

Copilot · 2025-11-13T20:19:59Z

Fix clipboard copy formatting based on selection dimensions in Stack Viewer

Issue: When copying a single cell value (e.g., "Last" column with value "16,867.276"), the clipboard contains "| 16,867.276 |" instead of just "16,867.276". Additionally, the formatting behavior was inconsistent for different selection patterns.

Root cause: The code in PerfDataGrid.xaml.cs was adding markdown table formatting (leading "| " and trailing " |") regardless of selection dimensions (columns × rows).

Changes Made:

The fix implements proper clipboard formatting based on selection dimensions:

Single column of data:

Single cell: Just the data, no '|' symbols, no headers
Multiple cells: Include column header at the top, NO '|' symbols

Multiple columns of data:

First and Last columns only (1 row): Just the data, NO '|' symbols, no headers (special time range case)
Any other multiple column selection: Include column headers and '|' symbols for markdown table format

Implementation:

Added tracking for m_numSelectedColumns and m_numSelectedRows to distinguish selection dimensions
Added detection for the special First/Last column combination (time range selection via m_isFirstLastSelection)
Updated header inclusion logic to conditionally add headers based on selection pattern
Updated pipe symbol logic to add markdown table delimiters for all multiple column selections except the First/Last special case
Fixed range morphing logic to only apply to First/Last selections, preventing missing newlines for other 2-cell selections

Technical Details:

The fix tracks:

Total cells (m_numSelectedCells) - for range handling
Unique columns (m_numSelectedColumns) - for format decisions
Unique rows (m_numSelectedRows) - for format decisions
First/Last selection (m_isFirstLastSelection) - special case detection for time range selections

Header inclusion:

Single cell: no header
First/Last special case: no header
Single column + multiple cells: include header
Multiple columns: include header (unless First/Last case)

Pipe symbols (markdown table format):

Multiple columns: add pipes (unless First/Last case)
Single column or First/Last case: no pipes

Range morphing (combining on one line):

Only applies to First/Last special case
Prevents missing newlines for other 2-cell selections

Security Summary:

No security vulnerabilities introduced by this change
Change is limited to clipboard formatting logic

Note: Build has pre-existing dependency issues with missing NuGet packages (unrelated to this change).

Original prompt

This section details on the original issue you should resolve

<issue_title>CTR+C single cell value in Stack Viewer wraps text in "|"</issue_title>
<issue_description>Version: 3.1.28

Really minor issue.
Feel free to close this if this is by design or if that has been like that since forever.

IMO this used to be different. Background: I sometimes copy/paste values between stack viewer and Event-Viewer and I just noticed this.

Issue:

Open any stack viewer

Select any single cell value (eg. "Last")

Paste it: You see eg.
| 16,867.276 |
IMO this should be
16,867.276
instead.

</issue_description>

Comments on the Issue (you are @copilot in this section)
@brianrob You're right - this is a recent regression caused by a change to better support copying and pasting in to markdown. I agree that the behavior should be to just copy the value for a single cell, but if multiple are selected, we should treat it as a table. Let's assign this one to copilot.

Fixes CTR+C single cell value in Stack Viewer wraps text in "|" #2331

💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

When copying a single cell value from Stack Viewer, the clipboard now contains just the value without markdown table delimiters. Multiple cell selections still use markdown table format with leading "| " and trailing " |" characters. This fixes the regression where single cell copy would wrap values in "|" characters unnecessarily. Co-authored-by: brianrob <[email protected]>

brianrob · 2025-11-14T00:25:09Z

@copilot, there is some behavior that is not correct. This mostly works, but there are a few corner cases that don't work. One or two cells on top of one another, when copied and pasted, show up incorrectly.

Example: The name column:

module ntoskrnl <<ntoskrnl!?>> module code <<code!?>>

Should be:

Name
module ntoskrnl <<ntoskrnl!?>>
module code <<code!?>>

Example: The First (timestamp) column:

Sometimes shows up as "27.462 27.462". Sometimes as:

27.462
27.462

Should be:

First
27.462
27.462

Track total selected cells count to properly handle: - 1 cell: no markdown delimiters - 2 cells: no markdown delimiters (range handling) - 3+ cells: markdown table format with delimiters This fixes the corner case where selecting multiple cells from the same column (e.g., "module" and "ntoskrnl" vertically) would not properly format as a markdown table. Co-authored-by: brianrob <[email protected]>

Copilot · 2025-11-14T00:30:02Z

@copilot, there is some behavior that is not correct. This mostly works, but there are a few corner cases that don't work. One or two cells on top of one another, when copied and pasted, show up inc...

Fixed in commit a07effc. The issue was that the original fix only checked columns per row (e.ClipboardRowContent.Count) instead of total selected cells. Now tracking m_numSelectedCells to properly handle:

1 cell: no markdown delimiters
2 cells: no markdown delimiters (preserves range behavior)
3+ cells: markdown table format

This correctly handles vertically stacked selections like the Name column example you mentioned.

brianrob · 2025-11-14T00:46:04Z

@copilot, this still isn't working properly. How it should work:

Single column of data:

Single cell: Just the data, nothing else.
Multiple cells: Include the column header at the top, no '|' symbols.

Multiple columns of data:

Single row: Just the data, no '|' symbols, no headers.
Multiple rows: Include the column headers at the top and include '|' symbols.

Updated logic to track columns and rows separately: - Single column selections: include header, NO pipes - Multiple columns + single row: NO header, NO pipes - Multiple columns + multiple rows: include header, YES pipes This properly handles all clipboard scenarios as requested. Co-authored-by: brianrob <[email protected]>

Copilot · 2025-11-14T00:50:27Z

@copilot, this still isn't working properly. How it should work:

Single column of data:
...

Fixed in commit afbc9d4. Now tracking selection dimensions (columns × rows) separately:

Single column:

1 cell: no header, no pipes
Multiple cells: header included, no pipes

Multiple columns:

Single row: no header, no pipes
Multiple rows: header included, pipes added

The logic now uses m_numSelectedColumns and m_numSelectedRows to determine formatting instead of just counting total cells.

brianrob

@copilot please address the comment.

brianrob · 2026-01-12T23:36:34Z

src/PerfView/StackViewer/PerfDataGrid.xaml.cs

+                    // Add markdown table formatting (| symbols) only when:
+                    // - Multiple columns AND multiple rows selected
+                    // Single column (any rows) or multiple columns in single row: no pipes
+                    bool shouldAddPipes = (m_numSelectedColumns > 1 && m_numSelectedRows > 1);


We do want to add pipe symbols for single rows when there are multiple columns selected. The one case where we don't want to add pipe symbols is when there is one row selected, two columns selected, and those cells are the last two columns (First and Last). We should detect this and adjust the value of shouldAddPipes.

Also, down below, we should update Grid.ClipboardCopyMode for all cases except the following:

A single cell is selected.

One row and two columns selected and the columns are the last two (First and Last).

Fixed in commit 079946b. Now:

Pipes added for all multiple column selections (including single rows)

Special case detected: 1 row + 2 columns = FirstColumn & LastColumn

First/Last special case: no pipes, no headers

All other multiple column selections: pipes and headers included

Updated clipboard logic: - Add pipes for any multiple column selection (not just multiple rows) - Detect First/Last column special case (1 row, 2 cols: First & Last) - Exclude headers and pipes for First/Last special case - Include headers for all multiple column selections except First/Last This addresses the requirement to add pipes for single rows with multiple columns, while handling the First/Last time range case. Co-authored-by: brianrob <[email protected]>

Copilot · 2026-01-12T23:41:26Z

@copilot please address the comment.

Addressed in commit 079946b.

brianrob · 2026-01-13T00:07:33Z

@copilot Everything works as I want it to with the exception of one case:

When a single column with exactly two rows is selected, the contents are missing a newline in between the two values. For example, when selecting two cells in the Inc column, I get this:

Inc
139 52.0

However, if I select three, I get this:

Inc
139
52
46

Somewhere, a newline is missing between 139 and 52.0.

Only set m_clipboardRangeStart/End for First/Last special case. This prevents the range morphing logic from triggering for normal 2-cell selections (like 2 cells in Inc column), which was removing the newline between values. The range morphing (combining on one line with space) should only apply to First/Last time range selections, not to any 2-cell selection. Co-authored-by: brianrob <[email protected]>

Copilot · 2026-01-13T00:10:19Z

@copilot Everything works as I want it to with the exception of one case:

When a single column with exactly two rows is selected, the contents are missing a newline in between the two values. For ex...

Fixed in commit 2bb092a. The issue was that the range morphing logic (which combines 2 values on one line with a space) was being triggered for any 2-cell selection, not just the First/Last special case. Now m_clipboardRangeStart and m_clipboardRangeEnd are only set when m_isFirstLastSelection is true, so the morphing only applies to First/Last time range selections. This preserves newlines for normal 2-cell single column selections.

brianrob

@copilot please address this comment.

brianrob · 2026-01-13T00:39:40Z

src/PerfView/StackViewer/PerfDataGrid.xaml.cs

-                    if (i == e.ClipboardRowContent.Count - 1)
-                    {
-                        morphedContent = morphedContent + " |";
+                        // Add a leading | character to the first column to ensure GitHub renders the content as table


Remove reference to GitHub - this is just a markdown table.

Fixed in commit 2b68cf2. Removed the GitHub reference and updated the comment to simply say "for markdown table format".

Updated comment to simply refer to "markdown table format" instead of "to ensure GitHub renders the content as table" since this is a general markdown table feature, not GitHub-specific. Co-authored-by: brianrob <[email protected]>

Copilot · 2026-01-13T00:45:11Z

@copilot please address this comment.

Addressed in commit 2b68cf2.

marklio

Overall, I'll have to lean on the testing here for correctness as this is a pretty convoluted data flow.

I'm almost wondering if what should happen is the cipboard contents should be entirely recalculated as text from the selected cells (or dual-registered as data/text so that pasting into excel would use the data and into something else would produce the markdown).

I'm also wondering if there is a package that does this in a way that would more readily convey intent and would possibly support a broader set of Markdown scenarios/richness.

If you wanted to merge as-is, I think that's likely totally fine, but wanted to provide this feedback.

src/PerfView/StackViewer/PerfDataGrid.xaml.cs

marklio · 2026-01-13T17:18:07Z

src/PerfView/StackViewer/PerfDataGrid.xaml.cs

+                var dataGrid = sender as DataGrid;
+                if (dataGrid != null && dataGrid.SelectedCells.Count > 0)


SUGGESTION: if (sender is Datagrid dataGrid && dataGrid.SelectedCells.Count > 0)

While this is a personal preference, it does prevent duplicative checks and also scopes dataGrid to only scenarios in which it isn't null.

I like this, but didn't implement it for this particular one because we depend on the variable later in the method and I didn't want to duplicate the cast.

src/PerfView/StackViewer/PerfDataGrid.xaml.cs

Initial plan

c40f773

Copilot AI assigned Copilot and brianrob Nov 13, 2025

Copilot started work on behalf of brianrob November 13, 2025 20:20 View session

Copilot AI changed the title ~~[WIP] Fix single cell value copy in stack viewer to avoid text wrapping~~ Fix single cell clipboard copy to exclude markdown table delimiters Nov 13, 2025

Copilot AI requested a review from brianrob November 13, 2025 20:29

Copilot finished work on behalf of brianrob November 13, 2025 20:29

Copilot started work on behalf of brianrob November 14, 2025 00:25 View session

Copilot finished work on behalf of brianrob November 14, 2025 00:31

Copilot started work on behalf of brianrob November 14, 2025 00:46 View session

Copilot AI changed the title ~~Fix single cell clipboard copy to exclude markdown table delimiters~~ Fix clipboard copy formatting based on selection dimensions in Stack Viewer Nov 14, 2025

Copilot finished work on behalf of brianrob November 14, 2025 00:52

brianrob reviewed Jan 12, 2026

View reviewed changes

Copilot started work on behalf of brianrob January 12, 2026 23:37 View session

Copilot finished work on behalf of brianrob January 12, 2026 23:42

Copilot AI requested a review from brianrob January 12, 2026 23:42

Copilot started work on behalf of brianrob January 13, 2026 00:08 View session

Copilot finished work on behalf of brianrob January 13, 2026 00:10

brianrob reviewed Jan 13, 2026

View reviewed changes

Copilot started work on behalf of brianrob January 13, 2026 00:43 View session

Remove GitHub reference from markdown table comment

2b68cf2

Updated comment to simply refer to "markdown table format" instead of "to ensure GitHub renders the content as table" since this is a general markdown table feature, not GitHub-specific. Co-authored-by: brianrob <[email protected]>

Copilot AI requested a review from brianrob January 13, 2026 00:45

Copilot finished work on behalf of brianrob January 13, 2026 00:45

brianrob marked this pull request as ready for review January 13, 2026 00:50

brianrob requested review from StephenMolloy, cincuranet, leculver, marklio and mconnew as code owners January 13, 2026 00:50

marklio requested changes Jan 13, 2026

View reviewed changes

Code Review Feedback

11214cf

marklio approved these changes Jan 14, 2026

View reviewed changes

brianrob merged commit 7a795f5 into main Jan 15, 2026
9 checks passed

brianrob deleted the copilot/fix-stack-viewer-text-wrap branch January 15, 2026 19:03

		var dataGrid = sender as DataGrid;
		if (dataGrid != null && dataGrid.SelectedCells.Count > 0)

Fix clipboard copy formatting based on selection dimensions in Stack Viewer #2332

Fix clipboard copy formatting based on selection dimensions in Stack Viewer #2332

Uh oh!

Conversation

Copilot AI commented Nov 13, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Changes Made:

Implementation:

Technical Details:

Security Summary:

Issue:

Comments on the Issue (you are @copilot in this section)

Uh oh!

brianrob commented Nov 14, 2025

Uh oh!

Copilot AI commented Nov 14, 2025

Uh oh!

brianrob commented Nov 14, 2025

Uh oh!

Copilot AI commented Nov 14, 2025

Uh oh!

brianrob left a comment

Choose a reason for hiding this comment

Uh oh!

brianrob Jan 12, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 12, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI commented Jan 12, 2026

Uh oh!

brianrob commented Jan 13, 2026

Uh oh!

Copilot AI commented Jan 13, 2026

Uh oh!

brianrob left a comment

Choose a reason for hiding this comment

Uh oh!

brianrob Jan 13, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 13, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI commented Jan 13, 2026

Uh oh!

marklio left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

marklio Jan 13, 2026

Choose a reason for hiding this comment

Uh oh!

brianrob Jan 13, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Copilot AI commented Nov 13, 2025 •

edited

Loading