[VitisAI] external_ep_library typo fix#2027
Open
akholodnamdcom wants to merge 1 commit intomicrosoft:mainfrom
Open
[VitisAI] external_ep_library typo fix#2027akholodnamdcom wants to merge 1 commit intomicrosoft:mainfrom
akholodnamdcom wants to merge 1 commit intomicrosoft:mainfrom
Conversation
Collaborator
|
akholodnamdcom is this pull-request needed for the next release? |
kunal-vaishnavi
approved these changes
Mar 25, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes a misspelled VitisAI provider option key so the Windows-specific logic can locate the configured external EP library when the correct option name is used.
Changes:
- Update the VitisAI provider option lookup key from
external_ep_libraytoexternal_ep_library.
Comment on lines
855
to
858
| if (provider_options.name == "VitisAI") { | ||
| if (const auto opt_it = std::find_if(provider_options.options.begin(), provider_options.options.end(), | ||
| [](const auto& pair) { return pair.first == "external_ep_libray"; }); | ||
| [](const auto& pair) { return pair.first == "external_ep_library"; }); | ||
| opt_it != provider_options.options.end()) { |
There was a problem hiding this comment.
Changing the VitisAI provider option key from "external_ep_libray" to "external_ep_library" is a user-facing behavior change: any existing configs/scripts using the old misspelling will no longer trigger this branch. Consider accepting both keys (and optionally emitting a deprecation warning when the misspelling is used) to preserve backwards compatibility while fixing the typo.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Depends on microsoft/onnxruntime#27647