fix(react-list): fix useList and useListItem as prop handling#36026
Open
dmytrokirpa wants to merge 4 commits intomicrosoft:masterfrom
Open
fix(react-list): fix useList and useListItem as prop handling#36026dmytrokirpa wants to merge 4 commits intomicrosoft:masterfrom
dmytrokirpa wants to merge 4 commits intomicrosoft:masterfrom
Conversation
📊 Bundle size reportUnchanged fixtures
|
|
Pull request demo site: URL |
285558f to
4c11090
Compare
dmytrokirpa
commented
Apr 22, 2026
dmytrokirpa
commented
Apr 22, 2026
layershifter
approved these changes
Apr 22, 2026
Hotell
approved these changes
Apr 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Summary
Companion to #35821. Isolates the hook-level test additions as a master-passing baseline, plus fixes an operator precedence bug that would have silently broken the
asprop whenprops.asis explicitly set.useList_unstableanduseListItem_unstable:props.as || navigationMode === 'composite' ? 'div' : DEFAULT_ROOT_EL_TYPEwas parsed as(props.as || navigationMode === 'composite') ? 'div' : DEFAULT_ROOT_EL_TYPE, meaning a truthyprops.asalways resolved to'div'.useList_unstableanduseListItem_unstable:listbox/optionroles, toggle viaSpacekey,onSelectionChangecallbackdivroot,grid/rowrolesasprop override (also serves as a regression test for the precedence fix)Why
These tests are useful independent of #35821 — they pin existing behavior so that the refactor in #35821 (which introduces
useListBase_unstableanduseListItemBase_unstableand delegates the original hooks to them) produces a reviewable diff. Any assertion that needs updating there surfaces a behavior change worth discussing.🤖 Generated with Claude Code