Make CCB Truncate Button Text Before Trying to Squish Buttons#2265
Merged
cbowdoin merged 1 commit intomicrosoft:mainfrom Apr 16, 2026
Merged
Conversation
Contributor
|
can we revert the max width change now? |
joannaquu
approved these changes
Apr 16, 2026
nodes11
reviewed
Apr 16, 2026
nodes11
approved these changes
Apr 16, 2026
Contributor
Author
We may still need it around for scenario where we want to truncate a scrolling CommandBar |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Platforms Impacted
Description of changes
This change makes it so titles in the CommandBar Buttons truncate before we start having to layout out buttons off the screen when the CommandBar is in a non scrollable mode.
To do this we set the content hugging priority of button with texts to be low leading to them getting truncated before buttons that do not have the capacity to be squished.
Binary change
(how is our binary size impacted -- see https://github.com/microsoft/fluentui-apple/wiki/Size-Comparison)
Verification
Scrolling CommandBar had no behavioral changes.
Tested with a resizable view to see titles with text getting shrinked before other buttons.
Visual Verification
| Before | After | |----------------------------------------------|--------------------------------------------| | Screenshot or description before this change | Screenshot or description with this change |Pull request checklist
This PR has considered:
Microsoft Reviewers: Open in CodeFlow