[DRAFT] Consume ebpf-extension-common#5075
Draft
LakshK98 wants to merge 6 commits intomicrosoft:mainfrom
Draft
Conversation
LakshK98
requested review from
Alan-Jowett,
dthaler,
matthewige,
mikeagun,
mtfriesen,
poornagmsft,
saxena-anurag and
shankarseal
as code owners
LakshK98
force-pushed
the
extension_dedup
branch
2 times, most recently
from
bbb79de to
923c091
Compare
LakshK98
changed the title
LakshK98
force-pushed
the
extension_dedup
branch
from
923c091 to
e145581
Compare
Contributor
LakshK98
force-pushed
the
extension_dedup
branch
from
e145581 to
5a795f7
Compare
Contributor
Contributor
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces a new shared submodule for eBPF extension rundown logic and refactors the codebase to use this shared implementation reducing code duplication. The changes also update project configuration files to include the new submodule and ensure proper build integration.
Shared eBPF extension rundown logic integration:
external/ebpf-extension-commonas a new submodule in.gitmodulesand referenced its commit inexternal/ebpf-extension-commonto provide common eBPF extension rundown code. [1] [2]ebpf-for-windows.slnto include new projects for both kernel-mode and user-mode builds of the shared rundown logic, with appropriate build configurations. [1] [2]netebpfext/sys/netebpfext.vcxprojto reference the shared rundown header files. [1] [2]Code refactoring to use shared rundown logic:
netebpfext/net_ebpf_ext_hook_provider.candnetebpfext/net_ebpf_ext_structs.h, replacing them with calls to the shared rundown API fromebpf_ext_rundown.h. This affects initialization, waiting, entering, and leaving rundown. [1] [2] [3] [4] [5] [6] [7] [8] [9] [10]netebpfext/net_ebpf_ext.cto include the shared rundown header and use the shared rundown function for cleanup. [1] [2]Description
Describe the purpose of and changes within this Pull Request.
Please reference an issue with a keyword such as Fixes #abc, Closes #xyz, etc., so the work can be tracked.
Testing
Do any existing tests cover this change? Are new tests needed?
Documentation
Is there any documentation impact for this change?
Installation
Is there any installer impact for this change?