Adding driver tests for proof of verification#4975
Open
nmlud21 wants to merge 43 commits intomicrosoft:mainfrom
Open
Adding driver tests for proof of verification#4975nmlud21 wants to merge 43 commits intomicrosoft:mainfrom
nmlud21 wants to merge 43 commits intomicrosoft:mainfrom
Conversation
31244b4 to
2d504c3
Compare
Signed-off-by: Nicholas L <nickl239@att.net>
Signed-off-by: Nicholas Ludwig <nludwig@microsoft.com>
Signed-off-by: Nicholas Ludwig <nludwig@microsoft.com>
Signed-off-by: Nicholas Ludwig <nludwig@microsoft.com>
Signed-off-by: Nicholas Ludwig <nludwig@microsoft.com>
Signed-off-by: Nicholas Ludwig <nludwig@microsoft.com>
Signed-off-by: Nicholas Ludwig <nludwig@microsoft.com>
Signed-off-by: Nicholas Ludwig <nludwig@microsoft.com>
Signed-off-by: Nicholas Ludwig <nludwig@microsoft.com>
Signed-off-by: Nicholas Ludwig <nludwig@microsoft.com>
Signed-off-by: Nicholas Ludwig <nludwig@microsoft.com>
Signed-off-by: Nicholas Ludwig <nludwig@microsoft.com>
Signed-off-by: Nicholas Ludwig <nludwig@microsoft.com>
Signed-off-by: Nicholas Ludwig <nludwig@microsoft.com>
…ries. Signed-off-by: Nicholas Ludwig <nludwig@microsoft.com>
shankarseal
reviewed
Mar 23, 2026
shankarseal
reviewed
Mar 23, 2026
Signed-off-by: Nicholas Ludwig <nludwig@microsoft.com>
Alan-Jowett
reviewed
Mar 31, 2026
Member
Alan-Jowett
left a comment
There was a problem hiding this comment.
Minor nit for overall test hygiene: if any of the REQUIRE() assertions below this point fail, bpf_object__close(object) on line 3661 will never execute, leaking the loaded driver.
Other tests in this file already use the RAII pattern to avoid this (e.g. line 1926, 2350, 2505):
auto object_cleanup = std::unique_ptr<bpf_object, decltype(&bpf_object__close)>(object, bpf_object__close);Would be nice to use the same pattern here so cleanup is guaranteed regardless of assertion outcomes.
Signed-off-by: Nicholas Ludwig <nludwig@microsoft.com>
shankarseal
reviewed
Apr 6, 2026
|
|
||
| Exit: | ||
| ebpf_close_registry_key(root_key); | ||
| return result; |
Collaborator
There was a problem hiding this comment.
Use EBPF_RETURN_RESULT
Contributor
Author
There was a problem hiding this comment.
@shankarseal EBPF_RETURN_RESULT is not used in ebpf_store_helper.c Should all functions be updated to use this as well?
shankarseal
reviewed
Apr 6, 2026
shankarseal
reviewed
Apr 6, 2026
Signed-off-by: Nicholas Ludwig <nludwig@microsoft.com>
Signed-off-by: Nicholas Ludwig <nludwig@microsoft.com>
Signed-off-by: Nicholas Ludwig <nludwig@microsoft.com>
Signed-off-by: Nicholas Ludwig <nludwig@microsoft.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Resolves #4715
Adding driver tests to validate that production signed eBPF programs can be loaded, and that non-production-signed programs are correctly rejected. Pulling production signed binaries from 1es Azure storage blobs.
Testing
This is adding a new test for proof of verification driver loading.
Documentation
None
Installation
None