fix: improve import error messages by chaining original exception (#4605)#7258
Open
ddarji1409 wants to merge 1 commit intomicrosoft:mainfrom
Open
fix: improve import error messages by chaining original exception (#4605)#7258ddarji1409 wants to merge 1 commit intomicrosoft:mainfrom
ddarji1409 wants to merge 1 commit intomicrosoft:mainfrom
Conversation
When optional dependencies are missing, the original ImportError was being suppressed (via `from None` or no `as e` capture), making it harder to diagnose the actual root cause (e.g. missing sub-dependency vs version conflict). - In `_ai_search.py`: capture `ImportError as e` and raise `from e` for both azure_openai and openai embedding provider paths, including the original error text in the message. - In `_text_canvas.py`: store the `ModuleNotFoundError` at import time and chain it when raising the deferred `ImportError` at call site. Fixes microsoft#4605 Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Contributor
|
@ddarji1409 please read the following Contributor License Agreement(CLA). If you agree with the CLA, please reply with the following information.
Contributor License AgreementContribution License AgreementThis Contribution License Agreement (“Agreement”) is agreed to by the party signing below (“You”),
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #4605 — improves import error diagnostics in
autogen-extby preserving the original exception rather than suppressing it.Changes:
tools/azure/_ai_search.py: captureImportError as eand raisefrom e(instead offrom None) for bothazure_openaiandopenaiembedding provider paths; also includes the original error text in the message so users see the root cause (e.g. missing sub-dependency likeazure-identity)memory/canvas/_text_canvas.py: store theModuleNotFoundErrorat import time and chain it when the deferredImportErroris raised at the call siteBefore:
After:
Test plan
openaiand verify the error message includes the originalModuleNotFoundErrortextazure-identityand verify the error message shows the specific missing moduleunidiffand callapply_patch()— verify chained exception is visible in traceback🤖 Generated with Claude Code