Skip to content

CmdPal: Make Dock stay on top of all other windows#46163

Open
jiripolasek wants to merge 3 commits intomainfrom
dev/jpolasek/f/46161-cmdpal-make-dock-stay-on-top
Open

CmdPal: Make Dock stay on top of all other windows#46163
jiripolasek wants to merge 3 commits intomainfrom
dev/jpolasek/f/46161-cmdpal-make-dock-stay-on-top

Conversation

@jiripolasek
Copy link
Copy Markdown
Collaborator

@jiripolasek jiripolasek commented Mar 16, 2026

Summary of the Pull Request

This PR makes Dock stay on top of all other windows:

  • Marks the Dock window as topmost when there is no full-screen window.
  • Adds a new option that allows the user to disable this behavior.
  • Adds a timer that polls the system API to determine whether a full-screen window is present.

Pictures? Pictures!

image
Screen.Recording.2026-03-16.192718.mp4

PR Checklist

  • Communication: I've discussed this with core contributors already. If the work hasn't been agreed, this work might be rejected
  • Tests: Added/updated and all pass
  • Localization: All end-user-facing strings can be localized
  • Dev docs: Added/updated
  • New binaries: Added on the required places
  • Documentation updated: If checked, please file a pull request on our docs repo and link it here: #xxx

Detailed Description of the Pull Request / Additional comments

Validation Steps Performed

- Marks the Dock window as topmost when there is no full-screen window.
- Adds a new option that allows the user to disable this behavior.
- Adds a timer that polls the system API to determine whether a full-screen window is present.
@jiripolasek jiripolasek self-assigned this Mar 16, 2026
@jiripolasek jiripolasek added Product-Command Palette Refers to the Command Palette utility CmdPal - Dock Issues related to the Command Palette Dock Don't merge - Hold for release Hold off on merging this PR, even if it's approved. labels Mar 16, 2026
@michaeljolley
Copy link
Copy Markdown
Contributor

Conflict @jiripolasek

Listen for ABN_FULLSCREENAPP instead of polling
SHQueryUserNotificationState on a timer.

This removes the periodic refresh work and updates the dock's topmost
state directly from appbar fullscreen notifications.
@jiripolasek jiripolasek added Needs-Review This Pull Request awaits the review of a maintainer. and removed Merge conflict 🙀 labels Mar 28, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CmdPal - Dock Issues related to the Command Palette Dock Needs-Review This Pull Request awaits the review of a maintainer. Product-Command Palette Refers to the Command Palette utility

Projects

Status: No status

Development

Successfully merging this pull request may close these issues.

Dock: Keep the Dock always on top

3 participants