Skip to content

Pin vulnerable transitive NuGet packages (SFI-ES5.2)#534

Open
naomizhengmsft wants to merge 1 commit into
mainfrom
sfi/es5.2/189d082f
Open

Pin vulnerable transitive NuGet packages (SFI-ES5.2)#534
naomizhengmsft wants to merge 1 commit into
mainfrom
sfi/es5.2/189d082f

Conversation

@naomizhengmsft

Copy link
Copy Markdown
Member
  • Microsoft.Bcl.Memory -> 10.0.4
  • System.Net.Http -> 4.3.4
  • System.Text.RegularExpressions -> 4.3.1

Added as direct overrides in the consuming csprojs. CPM not introduced. Verified via dotnet restore/build/test against nuget.org (ADO feed unreachable from build env).

S360-Run-Id: 189d082f-67ad-401e-b203-788bd7c886cf
S360-KPI: SFI-ES5.2
S360-Skill: dependabot:dependency-update-orchestrator
S360-Arm: dedicated_skill

- Microsoft.Bcl.Memory -> 10.0.4
- System.Net.Http      -> 4.3.4
- System.Text.RegularExpressions -> 4.3.1

Added as direct <PackageReference> overrides in the consuming csprojs.
CPM not introduced. Verified via dotnet restore/build/test against
nuget.org (ADO feed unreachable from build env).

S360-Run-Id: 189d082f-67ad-401e-b203-788bd7c886cf
S360-KPI: SFI-ES5.2
S360-Skill: dependabot:dependency-update-orchestrator
S360-Arm: dedicated_skill

@Ansul Ansul left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look to me from SFI compliance. I was wondering if it would be beneficial to move over the patched binaries to a store, if this is going to be continuous effort needing PR or is it just a one-time thing.

@naomizhengmsft

Copy link
Copy Markdown
Member Author

Changes look to me from SFI compliance. I was wondering if it would be beneficial to move over the patched binaries to a store, if this is going to be continuous effort needing PR or is it just a one-time thing.

Yes it's for SFI compliance. We have #535 PR to automate the PR creation process for these type of PRs as a way to automate this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants