Fix name for enum keys in a map holding structs #1531
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WardenGnaw
reviewed
Jan 7, 2026
When a map has enum as keys and any type of struct as values, the enum value that was used for the key would be replaced as if it was base class. As the VariableInformation class has a constructor that receives the names directly from the map, use that information to not allow the name override.
OXINARF
force-pushed
the
enum_key_struct_value_fix
branch
from
3e6ed65 to
62d944f
Compare
WardenGnaw
approved these changes
Jan 13, 2026
Member
|
@OXINARF Thank you for your contribution. I'll try to get this into the next insiders or release of the VS Code C++. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a map has enum as keys and any type of struct as values, the enum value that was used for the key would be replaced as if it was base class.
As the VariableInformation class has a constructor that receives the names directly from the map, use that information to not allow the name override.
Fixes microsoft/vscode-cpptools#12102