On recovery, set UVM descriptor SVN to minimum of existing KV value and startup endorsements

[Copilot]

During recovery, the node was unconditionally overwriting the UVM descriptor SVN with the value from the new node's endorsements. This could raise the SVN above what was previously stored, which is incorrect — recovery should never increase the SVN.

Changes

• src/node/uvm_endorsements.h/.cpp: Extracted a parse_svn utility function that parses an SVN string to size_t, reused by both matches_uvm_roots_of_trust and the new recovery logic.
• src/service/internal_tables_access.h: trust_node_uvm_endorsements now accepts a recovering flag. When true, reads the existing SVN from the KV for the same DID/feed and writes min(existing, new) using parse_svn. The feed entry is merged into the existing map for the DID, preserving other feeds rather than overwriting the entire map. A changed boolean tracks whether the map was actually modified (new feed, or SVN value differs), and the KV write is skipped entirely when nothing changed.
• src/node/rpc/node_frontend.h: Pass recovering (already computed in the /create handler) to trust_node_uvm_endorsements.
• CHANGELOG.md: Documented the behaviour change.

---

💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

[achamayou]

@copilot I am sure we have SVN comparison logic already somewhere, please find that and use it, factor it out if necessary in its own function, but don't replicate it inline like that.

[Copilot]

@copilot I am sure we have SVN comparison logic already somewhere, please find that and use it, factor it out if necessary in its own function, but don't replicate it inline like that.

Extracted parse_svn(const std::string&) into src/node/uvm_endorsements.h/.cpp and refactored both matches_uvm_roots_of_trust and trust_node_uvm_endorsements to use it. Removed the inline <charconv>/from_chars duplication from internal_tables_access.h. See commit e7296cc.

[Copilot]

Pull request overview

This PR modifies the UVM endorsements trust logic during node recovery to use the minimum SVN (Security Version Number) between the existing stored value and the new node's startup endorsements. This prevents a recovery from inadvertently raising the SVN requirement.

Changes:

• Extract parse_svn utility function into uvm_endorsements.h/.cpp, replacing duplicated inline parsing logic.
• Add a recovering parameter to trust_node_uvm_endorsements that applies min(existing, new) SVN selection during recovery.
• Pass the recovering flag from the /create handler and document the behavior change in CHANGELOG.md.

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.

Show a summary per file

File	Description
src/node/uvm_endorsements.h	Declares the new parse_svn utility function.
src/node/uvm_endorsements.cpp	Implements parse_svn and refactors existing SVN parsing to use it.
src/service/internal_tables_access.h	Adds recovering parameter and min-SVN logic to trust_node_uvm_endorsements.
src/node/rpc/node_frontend.h	Passes recovering flag to trust_node_uvm_endorsements.
CHANGELOG.md	Documents the new recovery SVN behavior.

---

You can also share your feedback on Copilot code review. Take the survey.

[Copilot]

@copilot I am sure we have SVN comparison logic already somewhere, please find that and use it, factor it out if necessary in its own function, but don't replicate it inline like that.

Already addressed in e7296cc — parse_svn was extracted into src/node/uvm_endorsements.h/.cpp and both call sites use it.

[achamayou]

@copilot capture a boolean value that tells us if we've actually updated the map (did or feed was not there, or svn has changed) and only write if we did make a change!

[Copilot]

@copilot capture a boolean value that tells us if we've actually updated the map (did or feed was not there, or svn has changed) and only write if we did make a change!

Done in b8b7f52. A changed boolean now tracks whether the feed is new or the SVN value differs; uvme->put is only called when changed is true. The recovery log message is also gated on changed.