Remove the last three occurrences of Field() and replace with GF. Def…#641
Draft
fyellin wants to merge 10 commits intomhostetter:developfrom
Draft
Remove the last three occurrences of Field() and replace with GF. Def…#641fyellin wants to merge 10 commits intomhostetter:developfrom
fyellin wants to merge 10 commits intomhostetter:developfrom
Conversation
…n still exists in _factory.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #641 +/- ##
===========================================
- Coverage 95.20% 95.11% -0.09%
===========================================
Files 48 48
Lines 6209 6209
===========================================
- Hits 5911 5906 -5
- Misses 298 303 +5 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Owner
|
Thanks for this. Currently on Also, I'm not sure why the linter is giving you a hard time. The same version of Ruff passed those unit tests a few hours ago... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #633.
Remove last three occurrences of Field in code. This PR does not delete the actual definition of
Field()in factory. However to verify that I had found all occurrences, I temporarily removed the definition ofFieldand ran all tests.I could not find any occurrences in documentation or strings (other than automatically generated files), but I may have missed some.