Skip to content

- presumably fixed bug #8

Open
lotruheawea wants to merge 1 commit intomhm-ufz:mainfrom
lotruheawea:fix_#7
Open

- presumably fixed bug #8
lotruheawea wants to merge 1 commit intomhm-ufz:mainfrom
lotruheawea:fix_#7

Conversation

@lotruheawea
Copy link
Copy Markdown

adresses #7,

  • reason: bbox comparison in shrink and enlarge routines is imprecise due to rounding errors
  • this occurs at larger grids
  • the PRECISION of 10 seems reasonable and fixed the setup of a 3600x7200 grid
  • needs to be checked and tested

Copy link
Copy Markdown
Member

@MuellerSeb MuellerSeb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

like it! One comment, then we are good to go.

import numpy as np

# precision for rounding to avoid numerical instabilities
PRECISION = 10
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could add this as an optional argument to the config yaml file.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants