Add an example structure + job for a new domain#110
Conversation
Closes mferretti#102 Signed-off-by: YuuGR1337 <yudhatamvan25@gmail.com>
Up to standards ✅🟢 Issues
|
mferretti
left a comment
There was a problem hiding this comment.
Thanks for the PR! The intent is right, but as it stands this can't merge — the change only adds a README section and doesn't include the example it describes.
The new README block points at:
config/structures/support_ticket.yamlconfig/jobs/file_support_ticket.yaml
…but neither file is in the diff (the PR touches README.md only), and they don't exist in the repo. So the documented command would fail for anyone copying it:
./gradlew :cli:run --args="execute --job config/jobs/file_support_ticket.yaml --count 20"
#102's acceptance criteria are about the example files themselves, not docs:
- Add
config/structures/support_ticket.yamlusing primitives, anenum[...], adate[...], and at least one nestedobject[...]/array[...]. - Add
config/jobs/file_support_ticket.yamlwriting JSON to a file. - The job generates valid output with
--count 20. - Re-running with the same
--seedproduces byte-for-byte identical output. - Files follow the naming conventions in
CLAUDE.md.
Could you add the two YAML files and confirm you've actually run the command above (and that a repeated run with the same seed is byte-for-byte identical)? The README blurb is a nice addition once the example it links to exists. Thanks!
mferretti
left a comment
There was a problem hiding this comment.
Thanks for this! Right now the PR only adds the README section — the two files it points to (config/structures/support_ticket.yaml, config/jobs/file_support_ticket.yaml) are not in the diff, so the documented command fails and none of the issue's acceptance criteria can be met (no job to generate output, nothing to seed-check).
To close #102 the PR needs the actual YAMLs:
- a structure using primitives +
enum[...]+date[...]+ a nestedobject[...]/array[...](note: a nestedobject[child]also needs the child structure file), - a
file_<entity>.yamljob writing JSON, - verified:
--count 20produces valid output and the same seed gives byte-for-byte identical runs.
Happy to share a working reference for all three if useful. Marking as request-changes for now.
Fixes #102