Skip to content

Add an example structure + job for a new domain#110

Draft
YuuGR1337 wants to merge 1 commit into
mferretti:mainfrom
YuuGR1337:fix/issue-102
Draft

Add an example structure + job for a new domain#110
YuuGR1337 wants to merge 1 commit into
mferretti:mainfrom
YuuGR1337:fix/issue-102

Conversation

@YuuGR1337

Copy link
Copy Markdown

Fixes #102


Closes mferretti#102

Signed-off-by: YuuGR1337 <yudhatamvan25@gmail.com>
@codacy-production

Copy link
Copy Markdown

Up to standards ✅

🟢 Issues 0 issues

Results:
0 new issues

View in Codacy

NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.

@mferretti mferretti left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! The intent is right, but as it stands this can't merge — the change only adds a README section and doesn't include the example it describes.

The new README block points at:

  • config/structures/support_ticket.yaml
  • config/jobs/file_support_ticket.yaml

…but neither file is in the diff (the PR touches README.md only), and they don't exist in the repo. So the documented command would fail for anyone copying it:

./gradlew :cli:run --args="execute --job config/jobs/file_support_ticket.yaml --count 20"

#102's acceptance criteria are about the example files themselves, not docs:

  • Add config/structures/support_ticket.yaml using primitives, an enum[...], a date[...], and at least one nested object[...]/array[...].
  • Add config/jobs/file_support_ticket.yaml writing JSON to a file.
  • The job generates valid output with --count 20.
  • Re-running with the same --seed produces byte-for-byte identical output.
  • Files follow the naming conventions in CLAUDE.md.

Could you add the two YAML files and confirm you've actually run the command above (and that a repeated run with the same seed is byte-for-byte identical)? The README blurb is a nice addition once the example it links to exists. Thanks!

@mferretti mferretti left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this! Right now the PR only adds the README section — the two files it points to (config/structures/support_ticket.yaml, config/jobs/file_support_ticket.yaml) are not in the diff, so the documented command fails and none of the issue's acceptance criteria can be met (no job to generate output, nothing to seed-check).

To close #102 the PR needs the actual YAMLs:

  • a structure using primitives + enum[...] + date[...] + a nested object[...]/array[...] (note: a nested object[child] also needs the child structure file),
  • a file_<entity>.yaml job writing JSON,
  • verified: --count 20 produces valid output and the same seed gives byte-for-byte identical runs.

Happy to share a working reference for all three if useful. Marking as request-changes for now.

@mferretti mferretti marked this pull request as draft July 8, 2026 06:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add an example structure + job for a new domain

2 participants