Update tests to run only when required modules are present#2349
Open
benowen-bom wants to merge 2 commits intometoppv:masterfrom
Open
Update tests to run only when required modules are present#2349benowen-bom wants to merge 2 commits intometoppv:masterfrom
benowen-bom wants to merge 2 commits intometoppv:masterfrom
Conversation
benowen-bom
changed the title
benowen-bom
added
the
MO review required
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses #2348.
A number of acceptance tests fail due to missing imports. This PR adds import skips to the specific tests that are failing to ensure the run only when the required module is present.
This also adds a change to the
test_apply_rainforests_calibrationthat moves the import from module level to function level to ensure that the tests are listed in pytest run as skips.Need to fix failing test on the conda-forge environmentThe failing test is unrelated to the fix in this PR. I've opened another ticket on this issue; see #2351.
Testing: