Changes that might help with intermittent Stochastic Noise failure - #2346
Merged
maxwhitemet merged 12 commits intoApr 27, 2026
Merged
Conversation
maxwhitemet
force-pushed
the
mobt_1114_stochastic_noise_failure
branch
from
April 16, 2026 11:06
94c38d9 to
3a85788
Compare
maxwhitemet
marked this pull request as ready for review
April 16, 2026 16:13
maxwhitemet
previously approved these changes
Apr 16, 2026
maxwhitemet
left a comment
maxwhitemet
left a comment
Contributor
There was a problem hiding this comment.
Thanks Gavin. Happy with the changes you have made.
I have made some PR-hosted changes to address some sources of np.nan.
mo-jbeaver
requested changes
Apr 21, 2026
mo-jbeaver
left a comment
mo-jbeaver
left a comment
Contributor
There was a problem hiding this comment.
All the tests ran successfully. I've commented on a few things, but potentially a second review of the code maybe beneficial.
… the function nan-resistant
maxwhitemet
force-pushed
the
mobt_1114_stochastic_noise_failure
branch
from
April 21, 2026 11:10
a94dbee to
26873d0
Compare
maxwhitemet
reviewed
Apr 21, 2026
maxwhitemet
left a comment
maxwhitemet
left a comment
Contributor
There was a problem hiding this comment.
Thanks @mo-jbeaver. I have implemented the suggested changes
mo-jbeaver
previously approved these changes
Apr 21, 2026
mo-jbeaver
left a comment
mo-jbeaver
left a comment
Contributor
There was a problem hiding this comment.
Happy with the change changes made and all tests ran successfully.
gavinevans
commented
Apr 22, 2026
gavinevans
left a comment
gavinevans
left a comment
Contributor
Author
There was a problem hiding this comment.
Thanks @maxwhitemet 👍
I've added a couple of minor suggestions.
| if not np.all(np.isfinite(result_db)): | ||
| # Repeat scaling from _to_dB to get a sub-threshold dB value for | ||
| # non-finite outputs. | ||
| sub_threshold_dB = 10.0 * np.log10(self.db_threshold) - 5 |
Contributor
Author
There was a problem hiding this comment.
Ideally, it might be good to do something like set self.arbitrary_offset = 5 in the __init__ method, and then use self.arbitrary_offset instead of 5 on this line, and also in the _to_dB method. Perhaps that would make 5 seem less like a magic number.
maxwhitemet
reviewed
Apr 27, 2026
maxwhitemet
left a comment
maxwhitemet
left a comment
Contributor
There was a problem hiding this comment.
Thanks @gavinevans. I have implemented your feedback.
| if not np.all(np.isfinite(result_db)): | ||
| # Repeat scaling from _to_dB to get a sub-threshold dB value for | ||
| # non-finite outputs. | ||
| sub_threshold_dB = 10.0 * np.log10(self.db_threshold) - 5 |
maxwhitemet
approved these changes
Apr 27, 2026
maxwhitemet
left a comment
maxwhitemet
left a comment
Contributor
There was a problem hiding this comment.
Happy with the changes made. Approved 👍
MoseleyS
added a commit
that referenced
this pull request
May 14, 2026
* master: Changed implementation from clipping to masking + added Unit Tests (#2366) Adding kwarg as CLI argument & updating acceptance tests. (#2377) Refactor Pollen index for daily and hourly to single plugin (#2372) EPPT-3259 fix fsi duplicate metadata (#2370) Changes to Pollen classes for refactoring cube long names and units of concentration (#2368) Eppt 3223 lifted index investigate why the values are wrong (#2365) Cast to the original dtype of the points in `expand_bounds` (#2367) Changes that might help with intermittent Stochastic Noise failure (#2346)
MoseleyS
added a commit
that referenced
this pull request
May 15, 2026
* master: MOBT-1148 Add subperiod-selector tool (#2373) Revert "change ApplyDecisionTree categorical cube dtype from int32 to int16 (…" (#2382) change ApplyDecisionTree categorical cube dtype from int32 to int16 (#2371) Changed implementation from clipping to masking + added Unit Tests (#2366) Adding kwarg as CLI argument & updating acceptance tests. (#2377) Refactor Pollen index for daily and hourly to single plugin (#2372) EPPT-3259 fix fsi duplicate metadata (#2370) Changes to Pollen classes for refactoring cube long names and units of concentration (#2368) Eppt 3223 lifted index investigate why the values are wrong (#2365) Cast to the original dtype of the points in `expand_bounds` (#2367) Changes that might help with intermittent Stochastic Noise failure (#2346) # Conflicts: # improver/categorical/subperiod_selector.py
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses https://github.com/metoppv/mo-blue-team/issues/1114
Description
This PR makes a few changes to try to help with the intermittent Stochastic Noise failures. Although as these failures are intermittent, and we haven't replicated these failures locally, these changes are speculative.
Testing: