Add copilot instructions #1000
Open
Add copilot instructions #1000
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
@copilot could you check the instructions added in this PR and see if you would be able to work nicely with them |
Contributor
pfebrer
reviewed
Jan 8, 2026
Contributor
pfebrer
left a comment
pfebrer
left a comment
There was a problem hiding this comment.
Thanks, I have just two comments
.github/copilot-instructions.md
Outdated
|
|
||
| When reviewing code, verify: | ||
|
|
||
| - Imports are absolute, not relative |
Contributor
There was a problem hiding this comment.
This is not true in general, no?
Contributor
Author
There was a problem hiding this comment.
Yes indeed. We rather use relative imports.
.github/copilot-instructions.md
Outdated
| - `documentation.py`: Defines `ModelHypers` and `TrainerHypers` Pydantic classes | ||
| - `model.py`: Implements `ModelInterface` from `utils/abc.py` | ||
| - `trainer.py`: Implements `TrainerInterface` from `utils/abc.py` | ||
| - **YAML validation**: Use `OmegaConf` → Pydantic validators in `utils/pydantic.py` → `check_architecture_options()` |
Contributor
There was a problem hiding this comment.
This sentence is not very clear imo, but maybe it works
Contributor
Author
|
Thanks we should also add line width as we often have linting issues |
Contributor
|
But this one should only be for comments or multi-line strings, which |
PicoCentauri
force-pushed
the
copilot-instructions
branch
from
dd6aafc to
97fc1bd
Compare
PicoCentauri
force-pushed
the
copilot-instructions
branch
from
97fc1bd to
f35927b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in the slack.
It make sense to also add hacks and tricks that we sometimes do to this file. @frostedoyster and @pfebrer if you have ideas just add them.
📚 Documentation preview 📚: https://metatrain--1000.org.readthedocs.build/en/1000/