Skip to content

NetworkType and NatType should not be optional #123

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
majst01 wants to merge 3 commits into
base: main
Choose a base branch
from
+51 −53
Open

NetworkType and NatType should not be optional #123

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b72f8d0
NetworkType and NatType should not be optional
majst01 Apr 10, 2026
a46c8dd
Merge branch 'main' of https://github.com/metal-stack/api into networ…
majst01 Apr 20, 2026
3d08d9d
Merge main
majst01 Apr 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions doc/index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7974,14 +7974,14 @@ <h3 id="metalstack.api.v2.Network">Network</h3>
<tr>
<td>type</td>
<td><a href="#metalstack.api.v2.NetworkType">NetworkType</a></td>
<td>optional</td>
<td></td>
<td><p>Type of the network </p></td>
</tr>

<tr>
<td>nat_type</td>
<td><a href="#metalstack.api.v2.NATType">NATType</a></td>
<td>optional</td>
<td></td>
<td><p>NATType of this network </p></td>
</tr>

Expand Down
28 changes: 13 additions & 15 deletions go/metalstack/api/v2/network.pb.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

12 changes: 6 additions & 6 deletions go/tests/api_scopes_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -141,14 +141,14 @@ func Test_FieldNumbering(t *testing.T) {

for _, mt := range fd.GetMessageType() {
var (
firstFiled = true
firstField = true
lastNumber int32
)

for _, field := range mt.GetField() {
if field.Number != nil {
if firstFiled {
firstFiled = false
if firstField {
firstField = false
} else {
if lastNumber+1 != *field.Number {
errs = append(errs, fmt.Errorf("%s %s %s %d != %d", filename, *mt.Name, *field.Name, lastNumber+1, *field.Number))
Expand All @@ -161,14 +161,14 @@ func Test_FieldNumbering(t *testing.T) {

for _, et := range fd.GetEnumType() {
var (
firstFiled = true
firstField = true
lastNumber int32
)

for _, value := range et.GetValue() {
if value.Number != nil {
if firstFiled {
firstFiled = false
if firstField {
firstField = false
} else {
if lastNumber+1 != *value.Number {
errs = append(errs, fmt.Errorf("%s %s %s %d != %d", filename, *et.Name, *value.Name, lastNumber+1, *value.Number))
Expand Down
8 changes: 4 additions & 4 deletions js/metalstack/api/v2/network_pb.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -393,15 +393,15 @@ export type Network = Message<"metalstack.api.v2.Network"> & {
/**
* Type of the network
*
* @generated from field: optional metalstack.api.v2.NetworkType type = 12;
* @generated from field: metalstack.api.v2.NetworkType type = 12;
*/
type?: NetworkType;
type: NetworkType;
/**
* NATType of this network
*
* @generated from field: optional metalstack.api.v2.NATType nat_type = 13;
* @generated from field: metalstack.api.v2.NATType nat_type = 13;
*/
natType?: NATType;
natType: NATType;
/**
* VRF of this network has this VNI.
*
Expand Down
Loading
Loading