Fixes feed overlap when ErrorBar appears #734#735
Open
rajeev-k47 wants to merge 2 commits intometabrainz:mainfrom
Open
Fixes feed overlap when ErrorBar appears #734#735rajeev-k47 wants to merge 2 commits intometabrainz:mainfrom
rajeev-k47 wants to merge 2 commits intometabrainz:mainfrom
Conversation
Contributor
Author
|
Hey @07jasjeet, this small PR fixes the layout issue on the feed screen. Please take a look and let me know if any changes are needed. |
07jasjeet
requested changes
Mar 14, 2026
app/src/main/java/org/listenbrainz/android/ui/screens/feed/FeedScreen.kt
Outdated
Show resolved
Hide resolved
Contributor
Author
|
@07jasjeet I have done the changes requested, now instead of hard coded padding it dynamically adds the combined padding of ErrorBarHeight and NavigationChipsHeight to the content. Tested on different DPI settings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #734
AC6AD53EC31FBAC8E6F3F728248B3406-Screen_Recording_20260309_033242_ListenBrainz.Debug.mp4
Fixes the layout overlap on the Feed screen when the ErrorBar appears. Previously, when a network error occurred, the ErrorBar increased the height of the header section (TopBar + ErrorBar + NavigationChips), but the feed list below did not adjust its starting offset. This caused feed tiles to overlap with the header area.
The fix makes the spacer at the top of the feed list dynamic instead of fixed. Its height now depends on whether the ErrorBar is visible. When the error banner appears, the spacer becomes larger so the feed content starts lower and remains correctly positioned below the header. When there is no error, the spacer keeps the normal height.
This keeps the layout consistent and prevents the overlap issue across all feed tabs (My Feed, Follow Listens, and Similar Listens).