Merged
Conversation
07jasjeet
requested changes
Mar 8, 2026
Collaborator
07jasjeet
left a comment
07jasjeet
left a comment
There was a problem hiding this comment.
As far as implementation goes, we should not store which listens were deleted. We should keep it similar to desktop and show a pop up saying that the listen is scheduled for deletion. Refreshing should show the listen again.
Also, I think we should follow up on progress of https://tickets.metabrainz.org/browse/LB-1141 and see if staged_for_deletion key is sent in Listen metadata.
app/src/main/java/org/listenbrainz/android/service/ListensService.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/org/listenbrainz/android/repository/listens/ListensRepositoryImpl.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/org/listenbrainz/android/ui/screens/profile/listens/ListensScreen.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/org/listenbrainz/android/ui/screens/profile/listens/ListensScreen.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/org/listenbrainz/android/ui/screens/profile/listens/ListensScreen.kt
Show resolved
Hide resolved
app/src/main/java/org/listenbrainz/android/viewmodel/ListensViewModel.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/org/listenbrainz/android/viewmodel/SocialViewModel.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/org/listenbrainz/android/ui/screens/profile/ProfileScreen.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/org/listenbrainz/android/ui/components/ListenCardSmall.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/org/listenbrainz/android/ui/screens/feed/SocialDropdown.kt
Outdated
Show resolved
Hide resolved
anuj990
commented
Mar 10, 2026
Contributor
Author
anuj990
left a comment
anuj990
left a comment
There was a problem hiding this comment.
@07jasjeet
i have made the marked changes now this implementation relies on server response
07jasjeet
requested changes
Mar 14, 2026
app/src/main/java/org/listenbrainz/android/ui/screens/feed/SocialDropdown.kt
Show resolved
Hide resolved
app/src/main/java/org/listenbrainz/android/ui/screens/playlist/PlaylistDetailScreen.kt
Show resolved
Hide resolved
| }, | ||
| goToArtistPage = goToArtistPage, | ||
| onClick = { | ||
| onTrackClick(playlist) |
Collaborator
There was a problem hiding this comment.
Same here, unnecessary/un-related change. Its always preferred to have named arguments.
| snackbarState.showSnackbar(it) | ||
| }, | ||
| onClick = { | ||
| metadata.trackMetadata?.let { playListen(it) } |
Collaborator
|
Thanks for the contribution @anuj990! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pr Fixes #615
Implemented Delete Listen
Added DeleteListen data class,implemented ListensRepositoryImpl and ListensService ,
instant Listens remove,
Screen Recording
WhatsApp.Video.2026-03-02.at.4.57.54.PM.mp4