Consolidate NcclxConfig into shared meta/ directory (#2059)#2059
Open
minsii wants to merge 1 commit intometa-pytorch:mainfrom
Open
Consolidate NcclxConfig into shared meta/ directory (#2059)#2059minsii wants to merge 1 commit intometa-pytorch:mainfrom
minsii wants to merge 1 commit intometa-pytorch:mainfrom
Conversation
meta-cla
bot
added
the
CLA Signed
Contributor
minsii
added a commit
to minsii/torchcomms-1
that referenced
this pull request
Apr 13, 2026
Summary: Pull Request resolved: meta-pytorch#2059 Move NcclxConfig.cc and NcclxConfig.h from per-version directories (v2_27/meta/, v2_28/meta/, v2_29/meta/) into the shared ncclx/meta/ directory, and relocate ncclxParseCommConfig from each version's src/init.cc into meta/NcclxConfig.cc: - sl mv v2_29/meta/NcclxConfig.{cc,h} to meta/ to preserve history - Remove identical copies from v2_27/meta/ and v2_28/meta/ - Move ncclxParseCommConfig function definition from all 3 src/init.cc into meta/NcclxConfig.cc - Update all 3 def_build.bzl to reference shared meta/NcclxConfig.{cc,h} - Include path "meta/NcclxConfig.h" unchanged for all consumers Differential Revision: D98925499
minsii
force-pushed
the
export-D98925499
branch
from
11d885f to
b848e2e
Compare
meta-codesync
bot
changed the title
Summary: Pull Request resolved: meta-pytorch#2059 Move NcclxConfig.cc and NcclxConfig.h from per-version directories (v2_27/meta/, v2_28/meta/, v2_29/meta/) into the shared ncclx/meta/ directory, and relocate ncclxParseCommConfig from each version's src/init.cc into meta/NcclxConfig.cc: - sl mv v2_29/meta/NcclxConfig.{cc,h} to meta/ to preserve history - Remove identical copies from v2_27/meta/ and v2_28/meta/ - Move ncclxParseCommConfig function definition from all 3 src/init.cc into meta/NcclxConfig.cc - Update all 3 def_build.bzl to reference shared meta/NcclxConfig.{cc,h} - Include path "meta/NcclxConfig.h" unchanged for all consumers Reviewed By: YulunW Differential Revision: D98925499
minsii
force-pushed
the
export-D98925499
branch
from
b848e2e to
5024d41
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Move NcclxConfig.cc and NcclxConfig.h from per-version directories (v2_27/meta/, v2_28/meta/, v2_29/meta/) into the shared ncclx/meta/ directory, and relocate ncclxParseCommConfig from each version's src/init.cc into meta/NcclxConfig.cc:
Reviewed By: YulunW
Differential Revision: D98925499