Fix CI: Dart package imports, dart analyze exclusion, C++ language filter, CMakeLists source file#4
Closed
Fix CI: Dart package imports, dart analyze exclusion, C++ language filter, CMakeLists source file#4
Conversation
…r, CMakeLists source file Agent-Logs-Url: https://github.com/meta-flutter/appstream_dart/sessions/6664969a-4d0c-4adf-be30-e1d82368a5c2 Co-authored-by: jwinarske <12262875+jwinarske@users.noreply.github.com>
Copilot created this pull request from a session on behalf of
jwinarske
March 30, 2026 00:58
View session
Agent-Logs-Url: https://github.com/meta-flutter/appstream_dart/sessions/e427db62-608c-401f-9b05-a76f4f2bc9f2 Co-authored-by: jwinarske <12262875+jwinarske@users.noreply.github.com>
…-dev ubuntu-latest picks clang++-19 by default, which fails linking sanitizer builds because libclang_rt.asan_static.a is missing. Pin the compiler to gcc/g++ (which ships its own sanitizer runtimes) and add libclang-rt-19-dev as a fallback. Signed-off-by: Joel Winarske <joel.winarske@outlook.com>
Fix empty language string ("") in AppStreamParser::doParse to correctly
keep only default (untagged) values instead of treating it as keep-all.
Rewrite benchmark_parser.cpp to use actual API: parseToSink, create,
fd-based XmlScanner, Component::Type enum, and pool.size(). Suppress
nodiscard warnings in test_string_pool.cpp
Signed-off-by: Joel Winarske <joel.winarske@outlook.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
3.4.0to3.10.0in bothbuild-and-testandcode-qualityjobs (to matchpubspec.yaml sdk: ^3.10.0)💬 Send tasks to Copilot coding agent from Slack and Teams to turn conversations into code. Copilot posts an update in your thread when it's finished.