Skip to content

Fix CI: missing dart_api_dl.c and mismatched Dart SDK version#3

Merged
jwinarske merged 3 commits intomainfrom
copilot/fix-failing-ci-jobs-again
Mar 30, 2026
Merged

Fix CI: missing dart_api_dl.c and mismatched Dart SDK version#3
jwinarske merged 3 commits intomainfrom
copilot/fix-failing-ci-jobs-again

Conversation

Copy link
Copy Markdown
Contributor

Copilot AI commented Mar 29, 2026

  • Fix CMakeLists.txt, Dart SDK version (previous sessions)
  • Fix C++ test 85 (MMAP_FAILED), Dart test imports in test/ (previous session)
  • Revert keepAllLangslanguage="" keeps default values only (Dart test is authoritative)
  • Rename C++ test LangFilter_EmptyProcessesAll_LastWinsLangFilter_EmptyKeepsDefaultOnly with correct expected value
  • Fix wrong package:appstream/ imports in bin/main.dart, bin/query.dart, example/example.dart
  • Fix misleading comment in Dart test _langXml()

⌨️ Start Copilot coding agent tasks without leaving your editor — available in VS Code, Visual Studio, JetBrains IDEs and Eclipse.

…rt keepAllLangs for empty language

Agent-Logs-Url: https://github.com/meta-flutter/appstream_dart/sessions/b46828bd-0a3f-4ddc-a71b-4e4a44fc5353

Co-authored-by: jwinarske <12262875+jwinarske@users.noreply.github.com>
@jwinarske jwinarske marked this pull request as ready for review March 30, 2026 06:33
@jwinarske jwinarske merged commit 5bb8389 into main Mar 30, 2026
10 checks passed
@jwinarske jwinarske deleted the copilot/fix-failing-ci-jobs-again branch March 30, 2026 06:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants