Throttle GPS initial position warning #9045
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fifieldt
reviewed
Dec 22, 2025
|
|
||
| if (lastGpsSend == 0 || msSinceLastSend >= intervalMs) { | ||
| if (waitingForFreshPosition) { | ||
| if (waitingForFreshPosition && !Throttle::isWithinTimespanMs(lastWarn, ONE_MINUTE_MS)) { |
Member
There was a problem hiding this comment.
would you prefer to do this throttling, or just not have the log? I'd lean toward the latter since this is a log for a noop and we have adequate logging for position update ops.
Member
There was a problem hiding this comment.
Marking as approved anyway, support either decision :)
fifieldt
approved these changes
Dec 22, 2025
Contributor
|
I've got this one flagged as GPS verbose guarded one upstream |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.