Fix Rotary enc long press #9039
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
Collaborator
|
Sorry, missed seeing this one when it first came through. Looks reasonable |
jp-bennett
approved these changes
Jan 1, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rotary encoder INPUT_BROKER_SELECT_LONG events were not being generated on long press of the encoder select switch. Thus, upper case characters could not be entered in "Free Text" messages via the encoder.
The root cause was RotaryEncoderInterruptBase::runOnce() only being called once after RotaryEncoderInterruptBase::intPressHandler() because it always returned INT32_MAX.
The easy fix is to return 20 if the press is still detected and LONG_PRESS_DURATION has not passed.
🤝 Attestations
Tested on DIY NRF52 Promicro E22 board