Skip to content

DR2-118 | Warning on django 4#208

Open
wmaciejewskimer wants to merge 1 commit into
developfrom
DR2-118-Warning-on-django-4
Open

DR2-118 | Warning on django 4#208
wmaciejewskimer wants to merge 1 commit into
developfrom
DR2-118-Warning-on-django-4

Conversation

@wmaciejewskimer

Copy link
Copy Markdown
Collaborator

No description provided.

@wmaciejewskimer wmaciejewskimer linked an issue Mar 14, 2023 that may be closed by this pull request
@codecov

codecov Bot commented Mar 14, 2023

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 97.07%. Comparing base (70af1c6) to head (30e2a66).
⚠️ Report is 2 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #208      +/-   ##
===========================================
+ Coverage    97.05%   97.07%   +0.01%     
===========================================
  Files           42       43       +1     
  Lines          918      923       +5     
===========================================
+ Hits           891      896       +5     
  Misses          27       27              
Files with missing lines Coverage Δ
...005_remove_mfamethod_primary_is_active_and_more.py 100.00% <100.00%> (ø)
trench/models.py 96.15% <100.00%> (+0.07%) ⬆️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Comment thread trench/models.py
class MFAMethod(Model):
_BACKUP_CODES_DELIMITER = "|"

id = AutoField(primary_key=True)

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any reason for the switch from BigAutoField to normal sized AutoField?

On positioning here, this is fine since there is a single model, otherwise it might be preferable to specify this in apps.py

ex.

class TrenchConfig(AppConfig):
    default_auto_field = "django.db.models.BigAutoField"
    name = "trench"
    verbose_name = "django-trench"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

trench.MFAMethod warning

2 participants