fix: continue address tx pagination across mempool boundary - #143
Merged
Conversation
junderw
force-pushed
the
junderw/fix-txs-endpoint
branch
2 times, most recently
from
March 26, 2026 15:39
3667723 to
26213ac
Compare
The address tx history endpoints could stop pagination at the mempool/chain boundary when after_txid pointed to the last mempool transaction for an address or address group. The confirmed-history query was reusing after_txid whenever the mempool query returned no rows, even if that cursor only existed in mempool. This change makes the confirmed-history query reuse after_txid only when the cursor was actually found in chain history; mempool cursors now correctly fall through to the newest confirmed transactions. Co-authored-by: Saravanan Mani <228955468+saravanan7mani7@users.noreply.github.com>
junderw
force-pushed
the
junderw/fix-txs-endpoint
branch
from
March 26, 2026 15:47
26213ac to
98ae002
Compare
There was a problem hiding this comment.
Pull request overview
Fixes address transaction history pagination when after_txid points to the last mempool transaction, ensuring pagination continues into confirmed (chain) history instead of returning an empty page.
Changes:
- Adds
confirmed_after_txid()to ensure confirmed-history pagination only reusesafter_txidwhen the cursor is known to be in chain history. - Updates both single-address and multi-address tx history endpoints to use the new cursor selection logic.
- Adds unit tests covering the new cursor-selection behavior.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
mononaut
approved these changes
Apr 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #142
The address tx history endpoints could stop pagination at the mempool/chain boundary when after_txid pointed to the last mempool transaction for an address or address group. The confirmed-history query was reusing after_txid whenever the mempool query returned no rows, even if that cursor only existed in mempool. This change makes the confirmed-history query reuse after_txid only when the cursor was actually found in chain history; mempool cursors now correctly fall through to the newest confirmed transactions.