Open
Conversation
|
@meinaart please merge this pull requests. |
|
@meinaart could you look into this PR ? We need it ! |
|
@gbasto please look at my PR I made on your fork ! |
|
@meinaart This PR would be extremely useful ... I hope this project hasn't been abandoned! Please merge this PR. Thank you! |
Author
|
I've been using a patched version of cypress-plugin-snapshots with this change for the last 2 years and it has been working perfectly to me, however this PR still has no feedback from the repo maintainers. Is this project completely abandoned? @meinaart let me know if you need any help, otherwise I'll just close it as it's tickling my OCD anytime I look into my open PRs and I always find this one stalled there 😅 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds retry-ability to snapshot tests, by adding two new configuration options:
This is useful, for example, for cases when some tests are failing because the image snapshot is done before some images are loaded due to slow network.