Add method to get a value from a key/value#351
Open
Boog900 wants to merge 2 commits intomeilisearch:mainfrom
Open
Add method to get a value from a key/value#351Boog900 wants to merge 2 commits intomeilisearch:mainfrom
Boog900 wants to merge 2 commits intomeilisearch:mainfrom
Conversation
Member
|
Hey @Boog900 👋 Thank you for the change, however, I'm wondering if we could instead work on exposing the internal Cursor I use in the Iterators. What do you think? |
Contributor
Author
|
I would support that and it would allow me to do more things to make my code more efficient, I added this method as I didn't want to make too much of a change to the API and it was the least I needed to get my code working. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request
What does this PR do?
Adds a method to get a value from a (key, value). Although on the surface this may seem useless, if you define the values comparison function to only take into account part of the value then you can use this method to do direct lookups of multi-map values.
This method would probably be less necessary if we exposed Cursors, which I would like, however this is a much smaller change and fits my use-case.