feat: allow serializing handshake state - #217
Open
Stypox wants to merge 2 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
HandshakeState, to e.g. save the state to disk for handshakes that take a long time to completeRandom,Dh,Cipher,Hash,Kemtraits are all used dynamically, I used thetypetagtrait to serialize thoseserde_bytesfor longer onesserdeand the crypto libraries'SerializableStateblake2andblake3do not implementSerializableStateunfortunately, so in my first commit they are not enabled when theserdefeature is passedblake2as well, although the upstream PR is still pending: blake2: implement SerializableState RustCrypto/hashes#906 (so the cargo dependency currently points to my fork)Thanks for your work on Snow!