feat: add real-time recording visualization#105
Open
dotCipher wants to merge 1 commit intombailey:masterfrom
Open
feat: add real-time recording visualization#105dotCipher wants to merge 1 commit intombailey:masterfrom
dotCipher wants to merge 1 commit intombailey:masterfrom
Conversation
- Add visual feedback during voice recording (audio levels, duration, speech detection) - Integrate Rich library for live terminal UI - Configurable via VOICEMODE_RECORDING_VISUALIZATION (enabled by default) - Addresses product review Quick Win mbailey#4
Collaborator
|
Great idea for UX improvement! One architectural question to consider: Where can this be displayed when VoiceMode runs as an MCP server? When VoiceMode runs via A few possibilities:
The honest assessment is: this visualization is designed for terminal use and doesn't translate well to the MCP server model. It's really a feature for when you're running VoiceMode directly in a terminal. That said, it would still be valuable for:
What are your thoughts on the intended use case? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Real-Time Recording Visualization
Adds live visual feedback during voice recording to improve UX and help users understand what's happening during recording sessions.
What This Does
Shows real-time recording feedback with:
Example
Why This Matters
Users previously had no visual feedback during recording, leading to:
This PR solves these issues by making the recording process transparent and providing clear visual cues.
Implementation
New module (
voice_mode/recording_visualization.py):RecordingVisualizerclass with thread-safe updatesIntegration (
voice_mode/tools/converse.py):Configuration:
VOICEMODE_RECORDING_VISUALIZATION=falseDependencies:
rich>=13.0.0for terminal UITesting
Manual test script included (
test_visualization.py) that simulates:Documentation
Comprehensive guide added at
docs/features/recording-visualization.md:Changes
pyproject.toml- Added rich dependencyvoice_mode/config.py- AddedRECORDING_VISUALIZATION_ENABLEDsettingvoice_mode/recording_visualization.py- New visualization modulevoice_mode/tools/converse.py- Integrated visualizer into recording flowdocs/features/recording-visualization.md- Feature documentationtest_visualization.py- Manual test script@mbailey this is a mostly complete draft, I want to do some more extensive testing on it, but mainly wanted to get my idea down for some feedback 👍🏻 cheers!