Skip to content

feat: add @signaldb/electron integration package#2657

Open
poeck wants to merge 4 commits into
maxnowack:mainfrom
blinkdisk:electron
Open

feat: add @signaldb/electron integration package#2657
poeck wants to merge 4 commits into
maxnowack:mainfrom
blinkdisk:electron

Conversation

@poeck

@poeck poeck commented Mar 26, 2026

Copy link
Copy Markdown

Add an IPC bridge that lets Electron renderer processes use reactive Collections backed by persistence adapters running in the main process.

Add an IPC bridge that lets Electron renderer processes use reactive Collections backed by persistence adapters running in the main process.
@codecov

codecov Bot commented Mar 26, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (d2dccec) to head (dd18406).
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##              main     #2657    +/-   ##
==========================================
  Coverage   100.00%   100.00%            
==========================================
  Files           56        60     +4     
  Lines         1866      1998   +132     
  Branches       444       456    +12     
==========================================
+ Hits          1866      1998   +132     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@codecov

codecov Bot commented Mar 26, 2026

Copy link
Copy Markdown

Bundle Report

Changes will increase total bundle size by 36.14kB (0.48%) ⬆️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
@signaldb/electron 36.14kB 36.14kB (100%) ⬆️

@maxnowack

Copy link
Copy Markdown
Owner

Thanks for your PR! Quick question: why not just using a custom persistence adapter that handles the IPC communication combined with some receiver side in the main process?

@poeck

poeck commented Mar 28, 2026

Copy link
Copy Markdown
Author

I think the main advantage of this approach is that it gives you access to the collection in both the main process and the renderer process. If it were just a persistence adapter in the renderer, accessing it from the main process would be much more difficult, which is probably quite common. I would also need this for my use case, so I'd prefer this approach.

@poeck
poeck marked this pull request as ready for review April 2, 2026 13:21
@poeck

poeck commented Apr 2, 2026

Copy link
Copy Markdown
Author

I'll try to implement this in my own project and do some more testing there, but I think it's now ready for review 👍🏻

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants