Skip to content

fix(skills): add data safety checks to triage-issue and review-pr#1576

Open
worktrunk-bot wants to merge 1 commit intomainfrom
hourly/review-23177286387
Open

fix(skills): add data safety checks to triage-issue and review-pr#1576
worktrunk-bot wants to merge 1 commit intomainfrom
hourly/review-23177286387

Conversation

@worktrunk-bot
Copy link
Collaborator

Problem

The issue-triage bot (run 23175870605) created PR #1574 that silently deleted stale .wt-removing-* directories as a side effect during unrelated wt remove operations. While the fix passed all existing skill gate checks (reproducible bug, understood root cause, localized change, confident in correctness), it violated CLAUDE.md's data safety principles:

Never risk data loss without explicit user consent. Prefer failure over silent data loss. Explicit consent for destructive operations.

The maintainer closed #1574 with: "we cannot [have] paths being removed without it being extremely clear and expected."

The review-pr bot (run 23176220404) also reviewed #1574 and found "no issues" — it would have approved if it weren't self-authored.

Root cause

Neither skill explicitly checks for data safety compliance:

  • triage-issue Step 6 gates on reproducibility, localization, and confidence — but not on whether the fix introduces silent destructive operations
  • review-pr Step 3 checks correctness, edge cases, and failure paths — but doesn't check whether new code silently deletes files/directories

Fix

  • triage-issue: Add data safety as a 5th gate condition in Step 6 — the bot must verify its fix doesn't silently delete, remove, or overwrite user data
  • review-pr: Add a "Data safety" checklist item under Correctness that flags silent cleanup, implicit destructive side effects, and removal without user visibility

Runs analyzed

Run Workflow Branch Finding
23175870605 claude-issue-triage main (issue #1572) Created fix PR #1574 with silent directory deletion — data safety violation
23176220404 claude-review fix/issue-1572 Reviewed #1574, found "no issues" — missed data safety violation
23175712053 claude-issue-triage main (issue #1571) Clean docs-only fix (PR #1573) — no issues
23175987564 claude-review fix/issue-1571 Clean review of docs PR — no issues
23177246360 claude-mention main Good response to maintainer feedback on #1574, saved memory — no issues
23176765241 claude-mention main Clean response on #1572 — no issues

🤖 Generated with Claude Code

The issue-triage bot created PR #1574 that silently deleted stale
.wt-removing-* directories during unrelated remove operations. While the
fix passed all existing gate checks (reproducible, localized, confident),
it violated CLAUDE.md's data safety principles — the maintainer closed it
because paths should never be removed without explicit user awareness.

The review-pr bot also missed this when reviewing the same PR.

Add data safety as an explicit gate check in triage-issue Step 6 and a
review checklist item in review-pr Step 3 so both skills flag silent
destructive operations.

Evidence: run 23175870605 (triage), run 23176220404 (review), PR #1574

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@worktrunk-bot worktrunk-bot added the claude-behavior Issues with Claude CI bot behavior label Mar 17, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

claude-behavior Issues with Claude CI bot behavior

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant