fix(skills): add data safety checks to triage-issue and review-pr#1576
Open
worktrunk-bot wants to merge 1 commit intomainfrom
Open
fix(skills): add data safety checks to triage-issue and review-pr#1576worktrunk-bot wants to merge 1 commit intomainfrom
worktrunk-bot wants to merge 1 commit intomainfrom
Conversation
The issue-triage bot created PR #1574 that silently deleted stale .wt-removing-* directories during unrelated remove operations. While the fix passed all existing gate checks (reproducible, localized, confident), it violated CLAUDE.md's data safety principles — the maintainer closed it because paths should never be removed without explicit user awareness. The review-pr bot also missed this when reviewing the same PR. Add data safety as an explicit gate check in triage-issue Step 6 and a review checklist item in review-pr Step 3 so both skills flag silent destructive operations. Evidence: run 23175870605 (triage), run 23176220404 (review), PR #1574 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The issue-triage bot (run 23175870605) created PR #1574 that silently deleted stale
.wt-removing-*directories as a side effect during unrelatedwt removeoperations. While the fix passed all existing skill gate checks (reproducible bug, understood root cause, localized change, confident in correctness), it violated CLAUDE.md's data safety principles:The maintainer closed #1574 with: "we cannot [have] paths being removed without it being extremely clear and expected."
The review-pr bot (run 23176220404) also reviewed #1574 and found "no issues" — it would have approved if it weren't self-authored.
Root cause
Neither skill explicitly checks for data safety compliance:
Fix
Runs analyzed
🤖 Generated with Claude Code