Merged
Conversation
add check that payload is not empty
onur-ozkan
reviewed
Mar 26, 2026
onur-ozkan
reviewed
Mar 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There are some
//TODOs in the code that can be removed//TODO verify this is no longer necessary since we're supporting both mavlink1 and mavlink2;//TODO verify that id_width of u8 is OK even in mavlink v1:MessageWriteError::MAVLink2Onlythat check for such cases// TODO: these lints are produced on a couple of cubepilot messages (..)//TODO checkin MavFrame::ser()