Skip to content

remove message STORM32_GIMBAL_MANAGER_INFORMATION from blacklist#478

Merged
onur-ozkan merged 1 commit intomavlink:masterfrom
pv42:remove-storm32-blacklist
Mar 19, 2026
Merged

remove message STORM32_GIMBAL_MANAGER_INFORMATION from blacklist#478
onur-ozkan merged 1 commit intomavlink:masterfrom
pv42:remove-storm32-blacklist

Conversation

@pv42
Copy link
Copy Markdown
Contributor

@pv42 pv42 commented Mar 18, 2026

The STORM32_GIMBAL_MANAGER_INFORMATION message had been blacklisted from generation due to inconsistent enum sizing not being supported (see mavlink/mavlink#1969). This is no longer an issue.

The generated code for GIMBAL_DEVICE_INFORMATION_DATA in both storm32.rs and common.rs:

impl MessageData for GIMBAL_DEVICE_INFORMATION_DATA {
    [..]
    fn deser(..) {
        [..]
        let tmp = buf.get_u16_le()?;
        __struct.cap_flags = GimbalDeviceCapFlags::from_bits(
            tmp as <GimbalDeviceCapFlags as Flags>::Bits,
        )
        [..]
    }
    fn ser(..) {
        [..]
        __tmp.put_u16_le(self.cap_flags.bits() as u16);
        [..]
    }
}

and for STORM32_GIMBAL_MANAGER_INFORMATION_DATA in storm32.rs

impl MessageData for STORM32_GIMBAL_MANAGER_INFORMATION_DATA {
    [..]
    fn deser(..) {
        [..]
        let tmp = buf.get_u32_le()?;
        __struct.device_cap_flags = GimbalDeviceCapFlags::from_bits(
            tmp as <GimbalDeviceCapFlags as Flags>::Bits,
        )
        [..]
    }
    fn ser(..) {
        [..]
        __tmp.put_u32_le(self.device_cap_flags.bits() as u32);
        [..]
    }
}

Copy link
Copy Markdown
Member

@onur-ozkan onur-ozkan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@onur-ozkan onur-ozkan merged commit 7103228 into mavlink:master Mar 19, 2026
51 checks passed
@pv42 pv42 deleted the remove-storm32-blacklist branch March 25, 2026 13:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants