make git optional to support offline and packaged builds#477
Merged
onur-ozkan merged 3 commits intomavlink:masterfrom Mar 19, 2026
Merged
make git optional to support offline and packaged builds#477onur-ozkan merged 3 commits intomavlink:masterfrom
onur-ozkan merged 3 commits intomavlink:masterfrom
Conversation
onur-ozkan
added
the
kind:improvement
Previously the build script unconditionally required `git` to update submodules. This breaks offline builds for vendored workspaces and environments without git installed where the files are already present but `.git` is absent. The new build flow is as follows: - Conditionally run `git submodule` only if the `mavlink` directory is a submodule. - Check the expected dialects existance and fail if they are missing. Signed-off-by: Onur Özkan <work@onurozkan.dev>
onur-ozkan
force-pushed
the
support-offline-builds
branch
from
7f463c3 to
9152a5c
Compare
onur-ozkan
force-pushed
the
support-offline-builds
branch
2 times, most recently
from
63337a9 to
fd14d65
Compare
Signed-off-by: Onur Özkan <work@onurozkan.dev>
onur-ozkan
force-pushed
the
support-offline-builds
branch
from
fd14d65 to
48677ee
Compare
Contributor
|
Changes look good, but the build requirements section in readme.md should be updated to reflect that git is no longer requried. Probably easiest to just remove the whole Build requirements section since users either
|
Signed-off-by: Onur Özkan <work@onurozkan.dev>
Member
Author
Right, it no longer makes sense. Removed it. |
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously the build script unconditionally required
gitto update submodules. This breaks offline builds for vendored workspaces and environments without git installed where the files are already present but.gitis absent.The new build flow is as follows:
git submoduleonly if themavlinkdirectory is a submodule.Drops the need for #474