Fix ConfigSection controls not expanding to full width#14236
Merged
DonLakeFlyer merged 1 commit intomavlink:masterfrom Mar 29, 2026
Merged
Fix ConfigSection controls not expanding to full width#14236DonLakeFlyer merged 1 commit intomavlink:masterfrom
DonLakeFlyer merged 1 commit intomavlink:masterfrom
Conversation
The RowLayout inside ConfigSection used absolute x/y positioning, so it floated at its natural implicit width instead of stretching to the background Rectangle. Anchor left/right with margins so the controls column fills the available width. Keep y positioning so the Rectangle height remains content-driven without a binding loop. Also update the VehicleConfigView search placeholder to say 'Search configuration...' instead of 'Search components...'.
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes layout behavior in the vehicle configuration UI so ConfigSection content stretches to the full width of its background (instead of only sizing to its children), and updates the configuration search placeholder text to better reflect what’s being searched.
Changes:
- Updated
ConfigSection.qmlto anchor the internalRowLayoutto the left/right edges of its parent rectangle with margins, allowing the controls column to fill available width. - Updated the Vehicle Setup search field placeholder text to “Search configuration...”.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
src/Vehicle/VehicleSetup/VehicleConfigView.qml |
Updates search placeholder text to match configuration search behavior. |
src/QmlControls/ConfigSection.qml |
Anchors the content layout to fill the section background width while keeping height content-driven. |
Contributor
Build ResultsPlatform Status
All builds passed. Pre-commit
Pre-commit hooks: 4 passed, 32 failed, 7 skipped. Test Resultslinux-sanitizers: 67 passed, 0 skipped Artifact Sizes
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
ConfigSectioncontrols (GCS Failsafe, RC Failsafe, Throttle Failsafe, etc.) don't expand to the full width of their background rectangle. They are only as wide as the controls within.Root Cause
The
RowLayoutinsideConfigSection.qmlused absolutex/ypositioning. This meant the RowLayout floated at its natural implicit width rather than stretching to fill the parent Rectangle, even though the Rectangle itself hadLayout.fillWidth: true.Fix
ypositioning (not top/bottom anchors) so the Rectangle's height remains content-driven viaimplicitHeightwithout creating a binding loop.