Settings: Add separate audioMuted setting to preserve volume on mute#14227
Merged
DonLakeFlyer merged 1 commit intomavlink:masterfrom Mar 27, 2026
Merged
Conversation
Add a dedicated audioMuted bool setting so muting no longer zeroes out the volume slider. The checkbox on the audio volume control now toggles the mute setting independently, preserving the user's chosen volume level when unmuting. If the user unmutes while volume is at 0, it resets to 75%. - Add audioMuted to App.SettingsGroup.json, AppSettings.h/.cc - Update AudioOutput to accept and respect the muted Fact - Rename _volume() to _volumeSetting(), add _mutedSetting() accessors - Wire enableCheckbox in General.SettingsUI.json to audioMuted - Add _appSettings binding to General.SettingsUI.json for readability
DonLakeFlyer
force-pushed
the
feature/audio-mute-setting
branch
from
4138564 to
5f51ccd
Compare
Contributor
Build ResultsPlatform Status
All builds passed. Pre-commit
Pre-commit hooks: 4 passed, 32 failed, 7 skipped. Test Resultslinux-sanitizers: 67 passed, 0 skipped Artifact Sizes
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a dedicated
audioMutedbool setting so muting no longer zeroes out the volume slider. Previously, muting set volume to 0 and unmuting restored to 100, losing the user's preferred volume level.Changes
audioMutedbool setting (default: false)init()accepts both volume and muted Facts;_setVolume()respects mute state; added_volumeSetting()/_mutedSetting()accessors for clarityaudioMutedinstead of zeroing volume; unmuting with volume at 0 resets to 75%; added_appSettingsbinding for readabilityAudioOutput::init()Behavior