Minor fixes: warnings, CI, and test stability#14209
Open
HTRamsey wants to merge 1 commit intomavlink:masterfrom
Open
Minor fixes: warnings, CI, and test stability#14209HTRamsey wants to merge 1 commit intomavlink:masterfrom
HTRamsey wants to merge 1 commit intomavlink:masterfrom
Conversation
github-actions
bot
added
github_actions
Contributor
There was a problem hiding this comment.
Pull request overview
This PR bundles a set of small build/CI/test fixes across the QGroundControl codebase, aiming to reduce warnings, improve CI reliability, stabilize sanitizer runs, and speed up macOS bundle signing.
Changes:
- Skip a flaky GStreamer RTSP URI validation test under AddressSanitizer.
- Add
QGC_PACKAGE_NAMEand use it forsetDesktopFileNameto silence Geoclue2 warnings. - Adjust CI doc deploy workflows to use the local
.github/actions/deploy-docsaction and parallelize macOS codesigning.
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
test/VideoManager/GStreamer/GStreamerTest.cc |
Skips a specific RTSP URI validation test under ASan to avoid timeouts. |
src/qgc_version.h.in |
Adds QGC_PACKAGE_NAME macro to the generated version header. |
src/Viewer3D/Providers/Osm/CMakeLists.txt |
Uses CPM’s SYSTEM YES for earcut_hpp to suppress dependency warnings. |
src/QGCApplication.cc |
Sets the desktop file name using QGC_PACKAGE_NAME to address Qt Positioning/Geoclue2 warnings. |
cmake/install/SignMacBundle.cmake |
Introduces parallel codesign helper and adjusts framework signing flow. |
.github/workflows/doxygen_deploy.yml |
Adds a checkout step intended to make the local deploy-docs action available. |
.github/workflows/docs_deploy.yml |
Adds a checkout step intended to make the local deploy-docs action available. |
HTRamsey
force-pushed
the
fix/minor-cleanups
branch
from
fbb5341 to
02951b5
Compare
Contributor
Build ResultsPlatform Status
All builds passed. Pre-commit
Pre-commit hooks: 4 passed, 32 failed, 7 skipped. Test Resultslinux-coverage: 67 passed, 0 skipped Code CoverageCoverage: 57.4% No baseline available for comparison Artifact Sizes
|
HTRamsey
force-pushed
the
fix/minor-cleanups
branch
4 times, most recently
from
b377291 to
8cd4978
Compare
HTRamsey
force-pushed
the
fix/minor-cleanups
branch
from
8cd4978 to
7a6752c
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #14209 +/- ##
=========================================
Coverage ? 25.47%
=========================================
Files ? 740
Lines ? 67710
Branches ? 31505
=========================================
Hits ? 17250
Misses ? 37788
Partials ? 12672
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
HTRamsey
force-pushed
the
fix/minor-cleanups
branch
from
7a6752c to
586044c
Compare
- Use CPM SYSTEM YES for earcut_hpp instead of qgc_disable_dependency_warnings - Set desktop file name to silence Geoclue2 positioning warning - Add checkout step in docs deploy workflows for local composite action - Skip GStreamer RTSP URI test under AddressSanitizer (300s timeout) - Parallelize macOS bundle codesigning
HTRamsey
force-pushed
the
fix/minor-cleanups
branch
from
586044c to
448f4fd
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
SYSTEM YESinstead ofqgc_disable_dependency_warningsfor INTERFACE librarysetDesktopFileNameusingQGC_PACKAGE_NAMEmacro to silenceqt.positioning.geoclue2warning.github/actions/deploy-docs) is available_testIsValidRtspUriunder AddressSanitizer (times out at 300s)Test plan