Merged
Conversation
Contributor
Build ResultsPlatform Status
All builds passed. Pre-commit
Pre-commit hooks: 3 passed, 31 failed, 7 skipped. Test Resultslinux-sanitizers: 62 passed, 0 skipped linux_gcc_64: 62 passed, 0 skipped Total: 124 passed, 0 skipped Artifact Sizes
No baseline available for comparison Updated: 2026-03-11 21:37:34 UTC • Triggered by: Android |
DonLakeFlyer
force-pushed
the
plan-view-cleanup
branch
from
7714010 to
4a5dbaa
Compare
Systematically rename the AltMode enum and all related types, properties, methods, signals, and QML components to use AltitudeFrame terminology, which better reflects that these represent MAVLink altitude reference frames rather than abstract modes. Key changes: - Enum: AltMode -> AltitudeFrame, values like AltModeMixed -> AltitudeFrameMixed - C++ properties/signals: altitudeMode -> altitudeFrame throughout - Methods: altitudeModeExtraUnits -> altitudeFrameExtraUnits, etc. - QML files: AltModeCombo -> AltFrameCombo, AltModeDialog -> AltFrameDialog - Pass currentAltFrame to AltFrameDialog open calls - Fix _missionItem -> missionItem in TransectStyleComplexItemTerrainFollow - Fix _amslAltAboveTerrainFact loading from wrong JSON key - Remove unused SettingsFixture::setAltitudeFrame no-op - JSON keys preserved for backward compatibility
Add count checks before accessing _visualItems.get(0) in PlanView.qml to prevent warnings during the gap between QML construction and MissionController.start() populating the model.
Ensures the tab selection resets when the tab bar becomes visible, preventing stale selection state when tabs are dynamically shown/hidden. Also calls _selectCurrentIndexButton() explicitly in case currentIndex is already 0 and onCurrentIndexChanged would not fire.
DonLakeFlyer
force-pushed
the
plan-view-cleanup
branch
from
4a5dbaa to
454e786
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 37 out of 37 changed files in this pull request and generated no new comments.
Comments suppressed due to low confidence (1)
src/QmlControls/AltFrameDialog.qml:16
- AltFrameDialog assumes
rgRemoveModesandupdateAltFrameFnare always provided; if either is omitted/null,rgRemoveModes.push(...)orupdateAltFrameFn(modeValue)will throw at runtime. Consider making theserequiredproperties (and/or defaultingrgRemoveModesto[]andupdateAltFrameFnto a no-op) to fail fast and avoid hard-to-debug QML exceptions when the dialog is reused elsewhere.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Terminology cleanup and minor bug fixes in Plan View code.
Commits
Rename home position label from "Launch" to "Home" — The map marker for the home/launch position now displays as "Home" which is more intuitive.
Rename AltitudeMode to AltitudeFrame throughout codebase — Systematically renames the AltMode enum, properties, signals, methods, and QML components to use AltitudeFrame terminology, which better reflects that these represent MAVLink altitude reference frames. JSON serialization keys are preserved for backward compatibility.
Guard _visualItems.get(0) against empty model during initialization — Adds count checks in PlanView.qml before accessing the first visual item, preventing QML warnings during the gap between construction and MissionController.start().
QGCTabBar: reset to first tab when becoming visible — Ensures tab selection resets when the tab bar becomes visible, preventing stale selection state.