Skip to content

feat(AnalyzeView): add MAVLink FTP log download for PX4 .ulg log files #13996

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
dakejahl wants to merge 1 commit into
base: master
Choose a base branch
from
+399 −1
Draft

feat(AnalyzeView): add MAVLink FTP log download for PX4 .ulg log files #13996

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions cmake/CustomOptions.cmake
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -104,6 +104,9 @@ option(QGC_DISABLE_APM_PLUGIN_FACTORY "Disable ArduPilot plugin factory" OFF)
option(QGC_DISABLE_PX4_PLUGIN "Disable PX4 plugin" OFF)
option(QGC_DISABLE_PX4_PLUGIN_FACTORY "Disable PX4 plugin factory" OFF)

# MAVLink FTP Log Download
option(QGC_ENABLE_MAVFTP_LOG_DOWNLOAD "Enable MAVLink FTP log download for PX4" ON)

# ============================================================================
# Platform-Specific Configuration
# ============================================================================
Expand Down
1 change: 1 addition & 0 deletions cmake/PrintSummary.cmake
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -104,6 +104,7 @@ OptionOutput("Enable Qt video backend " QGC_ENABLE_QT_VIDEOSTREAMI
OptionOutput("Disable APM MAVLink dialect " QGC_DISABLE_APM_MAVLINK)
OptionOutput("Disable APM plugin " QGC_DISABLE_APM_PLUGIN)
OptionOutput("Disable PX4 plugin " QGC_DISABLE_PX4_PLUGIN)
OptionOutput("Enable MAVLink FTP log download " QGC_ENABLE_MAVFTP_LOG_DOWNLOAD)
OptionOutput("Enable code coverage " QGC_ENABLE_COVERAGE)
OptionOutput("Enable AddressSanitizer " QGC_ENABLE_ASAN)
OptionOutput("Enable UndefinedBehaviorSanitizer " QGC_ENABLE_UBSAN)
Expand Down
4 changes: 4 additions & 0 deletions src/AnalyzeView/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,10 @@ target_sources(${CMAKE_PROJECT_NAME}

target_include_directories(${CMAKE_PROJECT_NAME} PRIVATE ${CMAKE_CURRENT_SOURCE_DIR})

if(QGC_ENABLE_MAVFTP_LOG_DOWNLOAD)
target_compile_definitions(${CMAKE_PROJECT_NAME} PRIVATE QGC_MAVFTP_LOG_DOWNLOAD)
Copy link

Copilot AI Feb 17, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The CMake option is named QGC_ENABLE_MAVFTP_LOG_DOWNLOAD but the compile definition is QGC_MAVFTP_LOG_DOWNLOAD (missing ENABLE_). For consistency with other features in the codebase (e.g., QGC_ENABLE_BLUETOOTH at src/Comms/CMakeLists.txt:78), consider using the same name for both the option and the definition.

Suggested change
target_compile_definitions(${CMAKE_PROJECT_NAME} PRIVATE QGC_MAVFTP_LOG_DOWNLOAD)
target_compile_definitions(${CMAKE_PROJECT_NAME} PRIVATE QGC_ENABLE_MAVFTP_LOG_DOWNLOAD)

Copilot uses AI. Check for mistakes.
endif()

# ----------------------------------------------------------------------------
# QML Module for Analyze View UI
# ----------------------------------------------------------------------------
Expand Down
Loading
Loading