Skip to content

Plan: Convert CameraSection to FactTextFieldSlider usage#13712

Merged
DonLakeFlyer merged 2 commits intomasterfrom
FTFSConvert
Dec 8, 2025
Merged

Plan: Convert CameraSection to FactTextFieldSlider usage#13712
DonLakeFlyer merged 2 commits intomasterfrom
FTFSConvert

Conversation

@DonLakeFlyer
Copy link
Copy Markdown
Collaborator

Screenshot 2025-12-07 at 3 03 36 PM

Copilot AI review requested due to automatic review settings December 7, 2025 23:16

This comment was marked as resolved.

Plus a few other visual tweaks for plan editing
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 13 out of 13 changed files in this pull request and generated 2 comments.

Comment on lines +201 to +204
width: parent.width
label: object.name
fact: object
enabled: !object.readOnly
Copy link

Copilot AI Dec 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[nitpick] Inconsistent property alignment in this FactTextFieldSlider. The width property uses 10 spaces after the colon, while label uses 14 spaces. For consistency, all properties should use the same alignment pattern. Consider aligning to the widest property name:

FactTextFieldSlider {
    width:      parent.width
    label:      object.name
    fact:       object
    enabled:    !object.readOnly
}
Suggested change
width: parent.width
label: object.name
fact: object
enabled: !object.readOnly
width: parent.width
label: object.name
fact: object
enabled: !object.readOnly

Copilot uses AI. Check for mistakes.
@DonLakeFlyer DonLakeFlyer merged commit 5a16346 into master Dec 8, 2025
27 checks passed
@DonLakeFlyer DonLakeFlyer deleted the FTFSConvert branch December 8, 2025 00:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants