Plan: Convert CameraSection to FactTextFieldSlider usage#13712
Merged
DonLakeFlyer merged 2 commits intomasterfrom Dec 8, 2025
Merged
Plan: Convert CameraSection to FactTextFieldSlider usage#13712DonLakeFlyer merged 2 commits intomasterfrom
DonLakeFlyer merged 2 commits intomasterfrom
Conversation
Collaborator
DonLakeFlyer
commented
Dec 7, 2025

Plus a few other visual tweaks for plan editing
33dbff1 to
b643041
Compare
Comment on lines
+201
to
+204
| width: parent.width | ||
| label: object.name | ||
| fact: object | ||
| enabled: !object.readOnly |
There was a problem hiding this comment.
[nitpick] Inconsistent property alignment in this FactTextFieldSlider. The width property uses 10 spaces after the colon, while label uses 14 spaces. For consistency, all properties should use the same alignment pattern. Consider aligning to the widest property name:
FactTextFieldSlider {
width: parent.width
label: object.name
fact: object
enabled: !object.readOnly
}
Suggested change
| width: parent.width | |
| label: object.name | |
| fact: object | |
| enabled: !object.readOnly | |
| width: parent.width | |
| label: object.name | |
| fact: object | |
| enabled: !object.readOnly |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.